Make Bootstrap task more robust #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalker-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
gerickson
approved these changes
Apr 20, 2020
woody-apple
approved these changes
Apr 20, 2020
.vscode/tasks.json
Outdated
| @@ -141,4 +151,4 @@ | |||
| ] | |||
| }, | |||
| ], | |||
| } | |||
| } | |||
There was a problem hiding this comment.
I'll make restyled understand that we have trailing whitespaces everywhere. Not sure why jq isn't picking this up...
rwalker-apple
commented
Apr 20, 2020
| @@ -96,7 +96,17 @@ | |||
| { | |||
| "label": "Bootstrap", | |||
| "type": "shell", | |||
| "command": "if [[ ! -f build/default/config.status ]]; then mkdir -p build/default; (cd build/default && ../../bootstrap-configure --enable-debug --enable-coverage); else ./bootstrap -w make; fi", | |||
| "command": [ | |||
| "if [[ ! -f build/default/config.status ]]; then", | |||
There was a problem hiding this comment.
yay, I found multi-line commands!
BroderickCarlin
approved these changes
Apr 21, 2020
|
@rwalker-apple Sorry conflict :( |
rwalker-apple
force-pushed
the
Make-Bootstrap-task-more-robust
branch
from
b721871 to
a96b224
Compare
|
rebased |
jelderton
approved these changes
Apr 21, 2020
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Dec 19, 2022
…C Commissioning over BLE
Merge in WMN_TOOLS/matter from feature/wifi_doc_upd_917_soc_ble to RC_1.0.2-1.0
Squashed commit of the following:
commit 41d646a4dc194e1100c7cc353090b5628a1fd9ab
Author: Manav Mehta <mamehta@silabs.com>
Date: Wed Dec 14 20:32:11 2022 +0530
Removed <br>'s in all modified files
commit c50639dfa6e3d6c02f853034f4a0c3fef58af845
Author: Manav Mehta <mamehta@silabs.com>
Date: Wed Dec 14 14:50:07 2022 +0530
Remove mentions of on-network commissioning
commit 2db024267ff16f55f09b70f69a73bfe1650f64e3
Author: Manav Mehta <mamehta@silabs.com>
Date: Wed Dec 14 13:46:35 2022 +0530
917 SoC BLE Document corrections
... and 1 more commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
configure.ac updates aren't detected by the vscode task Bootstrap, as a result, config.status doesn't realize it needs to reconfigure
Summary of Changes
run bootstrap if configure.ac is newer than configure