Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Fix crashes when BLE rendezvous disconnects unexpectedly #4414

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jan 19, 2021

A duplicate of #4413 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

mspang and others added 2 commits January 19, 2021 17:00
In BLE::OnBleEndPointConnectionClosed, the endpoint is already closed.
We try to close it again in the Transport::BLE destructor, causing a
crash.  Clear the endpoint in OnBleEndPointConnectionClosed to avoid
this case.

In addition, the OnRendezvousError callback ends up calling
RendezvousCleanup, which destroys the transport. We therefore cannot
call OnRendezvousConnectionClosed  after OnRendezvousError; |this| was
already freed in OnRendezvousError and we just need to return.
@restyled-io restyled-io bot added the restyled label Jan 19, 2021
@restyled-io restyled-io bot closed this Jan 19, 2021
@restyled-io restyled-io bot deleted the restyled/pull-4413 branch January 19, 2021 22:11
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from b430c42

File Section File VM
chip-lock.elf shell_root_cmds_sections -8 -8
chip-lock.elf text -8 -8
chip-lighting.elf shell_root_cmds_sections -8 -8
chip-lighting.elf text -8 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_loc,0,28
.debug_info,0,-1
.debug_line,0,-1
shell_root_cmds_sections,-8,-8
text,-8,-8
.debug_abbrev,0,-10
.debug_frame,0,-16

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_loc,0,28
.debug_info,0,-1
.debug_line,0,-1
shell_root_cmds_sections,-8,-8
text,-8,-8
.debug_abbrev,0,-10
.debug_frame,0,-16


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants