Part 2: feature/relative humidity measurement cluster #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2021
Damian-Nordic
approved these changes
May 26, 2021
src/app/clusters/relative-humidity-measurement-server/relative-humidity-measurement-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/relative-humidity-measurement-server/relative-humidity-measurement-server.cpp
Outdated
Show resolved
Hide resolved
| @@ -5647,7 +5759,7 @@ | |||
| ], | |||
| "attributes": [ | |||
| { | |||
| "name": "acceptsHeaderList", | |||
| "name": "accepts header list", | |||
There was a problem hiding this comment.
This change sounds unrelated to the current PR. Maybe rebasing this PR on top of master will remove it ?
There was a problem hiding this comment.
This is a change created by running the scripts/tools/zap_regen_all.py
src/app/clusters/relative-humidity-measurement-server/relative-humidity-measurement-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/relative-humidity-measurement-server/relative-humidity-measurement-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/relative-humidity-measurement-server/relative-humidity-measurement-server.cpp
Show resolved
Hide resolved
ghost
marked this pull request as ready for review
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jepenven-silabs and
msandstedt
vivien-apple
approved these changes
May 27, 2021
There was a problem hiding this comment.
Approving for TE3.
It seems like the result of this PR is mostly to expose a set of accessors to facilitate the manipulation of the relative humidity measurement cluster attributes.
It makes perfect sense to facilitate it imho, but I would rather prefer to autogenerate helpers code such as what is proposed in #7183, instead of having a lot of new clusters introduced into src/app/clusters.
msandstedt
approved these changes
May 27, 2021
- replace emberAfReadAttribute with emberAfReadServerAttribute - replace emberAfWriteAttribute with emberAfWriteServerAttribute - add emberAfRelativeHumidityMeasurementClusterPrintln - let the caller do the logging
The default values are populated by the attribute storage.
bzbarsky-apple
approved these changes
May 28, 2021
| var endpointClusterWithInit = | ||
| [ 'Basic', 'Identify', 'Groups', 'Scenes', 'Occupancy Sensing', 'On/off', 'Level Control', 'Color Control', 'IAS Zone' ]; | ||
| var endpointClusterWithInit = [ | ||
| 'Basic', 'Relative Humidity Measurement', 'Identify', 'Groups', 'Scenes', 'Occupancy Sensing', 'On/off', 'Level Control', |
There was a problem hiding this comment.
We don't need to add this here if we don't actually have an init method.
| @@ -4994,6 +4994,118 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "name": "Relative Humidity Measurement", | |||
There was a problem hiding this comment.
Should be on endpoint 1, not endpoint 0.
|
Size increase report for "esp32-example-build" from b4d7048
Full report output |
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
) * format endpointClusterWithInit for easier pull requests * add support for emberAfRelativeHumidityMeasurementClusterServerInitCallback * add server side relative humidity measurement cluster impl. * add relative humidity measurement cluster to controller-clusters.zap * Add new clusters to zap_cluster_list.py * Restyled by clang-format * apply fixes - replace emberAfReadAttribute with emberAfReadServerAttribute - replace emberAfWriteAttribute with emberAfWriteServerAttribute - add emberAfRelativeHumidityMeasurementClusterPrintln - let the caller do the logging * remove emberAfRelativeHumidityMeasurementClusterServerInitCallback impl. The default values are populated by the attribute storage. * fix year in copyright * remove unrelated clusters in zap_cluster_list.py * add relative humidity measurement to all-cluster-app.zap * fix relative humidity measurement includes * temptive fix for esp32/all-cluster-app * another try to fix all-cluster-app/esp32 * regen all * Remove unnecessary init callback from Relative Humidity Measurement cluster * Add Relative Humidity Measurement cluster on endpoint 1 also in all-clusters-app * Regenerate generated files Co-authored-by: Vivien Nicolas <vnicolas@apple.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add support for the relative humidity measurement cluster.
Change overview
Testing
Tested on custom accessory with relative humidity sensor. Test setup was similar to TE2.
HW Platform
Nordic nRF52840
Notes
Related PRs