Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: Fix temperature-measurement app #7305

Merged

Conversation

dhrishi
Copy link
Contributor

@dhrishi dhrishi commented Jun 2, 2021

Problem

temperature-measurement-app for ESP32 cannot compile at ToT

This is due to the latest changes related to temeprature-measurement cluster #7026

Change overview

The APIs emberAfPluginTemperatureMeasurementServerReadEventControl and emberAfPluginTemperatureMeasurementServerReadEventHandler are removed from the above PR and hence removing them from here

Testing

Locally compiled the temperature-measurement app with CMake

Fixes #7302

@dhrishi
Copy link
Contributor Author

dhrishi commented Jun 2, 2021

Note that, this might still require adding the actual calls for temperature-measurement cluster. But, currently, we use this example for optimization of the Flash/RAM footprint and hence the build failure needs to be fixed sooner.

@dhrishi dhrishi force-pushed the esp32/fix_temp-measurement-app branch from eeb4463 to ebacd67 Compare June 2, 2021 11:50
@dhrishi dhrishi changed the title ESP32: Fix temperature-measurement app after the addition of temperat… ESP32: Fix temperature-measurement app Jun 2, 2021
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fill out the testing template?

@andy31415 andy31415 dismissed woody-apple’s stale review June 2, 2021 20:41

Testing template was filled.

Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks to be in a 'gen' folder which implies generated file.

Is this true or not @vivien-apple
I have conflicting signals here: "gen" says generated, but our XML files do not contain 'events' as far as I am aware (at least https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/silabs/schema/zcl.xsd does not show it)

Approving assuming gen_event is not generated.

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is originally generated by Simplicity Studio, but has not been migrated to ZAP yet. See #3637 (comment)

@woody-apple woody-apple merged commit 0551e23 into project-chip:master Jun 3, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 temperature-measurement-app fails to build
5 participants