Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Introduce GetClusterInfoById #8749

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

erjiaqing
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

  • Update python/chip/clusters/ChipClusters.py to support looking up method.

Testing

  • Added test.TestPythonAPI(self) to test this API.

@andy31415
Copy link
Contributor

Could you separate out the 'generate file' from the rest of the commits to make code review easier?

@erjiaqing erjiaqing force-pushed the python/cluster-id-mapping branch 2 times, most recently from 45c2ffc to 03aa0c4 Compare August 4, 2021 07:34
@andy31415
Copy link
Contributor

@erjiaqing - merge conflicts

@github-actions
Copy link

github-actions bot commented Aug 5, 2021

Size increase report for "esp32-example-build" from 99ef92e

File Section File VM
chip-bridge-app.elf .flash.text 68 68
chip-all-clusters-app.elf .flash.text 80 80
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.flash.text,68,68
[Unmapped],0,-68

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.text,80,80
[Unmapped],0,-80

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit d2d11f4 into project-chip:master Aug 5, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* [python] Introduce GetClusterInfoById

* Run Codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mapping or lookup method of Cluster IDs for verification on Test Harness.
6 participants