Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Local and Peer in message tests into Alice and Bob #9561

Merged

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Sep 9, 2021

Problem

I found it is a little confused of using Local and Peer to name 2 arbitrary nodes in the test context.

Change overview

Rename Local and Peer in message tests into Alice and Bob with:

  • Local -> Bob
  • Peer -> Alice

Testing

Verified by unit-tests

@bzbarsky-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

Size increase report for "esp32-example-build" from eda07d5

File Section File VM
chip-temperature-measurement-app.elf .flash.text 32 32
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,32,32
[Unmapped],0,-32

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize


@bzbarsky-apple bzbarsky-apple merged commit 5a9c063 into project-chip:master Sep 11, 2021
@kghost kghost deleted the messaging-test-context-naming branch October 29, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants