Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RawEndPoint. #9614

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

This is unused in Matter. The only use case is ICMP, and Matter
doesn't do ICMP.

Problem

Dead (and buggy, which is why I was looking at it) code.

Change overview

Remove the code.

Testing

Unit tests still pass.

This is unused in Matter.  The only use case is ICMP, and Matter
doesn't do ICMP.
@github-actions
Copy link

Size increase report for "esp32-example-build" from eda07d5

File Section File VM
chip-ipv6only-app.elf .flash.text 172 172
chip-bridge-app.elf .flash.rodata -8 -8
chip-bridge-app.elf .flash.text -100 -100
chip-temperature-measurement-app.elf .flash.rodata -8 -8
chip-temperature-measurement-app.elf .flash.text -24 -24
chip-lock-app.elf .flash.text 32 32
chip-lock-app.elf .flash.rodata -8 -8
chip-all-clusters-app.elf .flash.rodata -8 -8
chip-shell.elf .flash.rodata -8 -8
chip-shell.elf .flash.text -28 -28
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,3924
.flash.text,172,172

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.flash.rodata,-8,-8
.symtab,0,-32
.strtab,0,-96
.flash.text,-100,-100
.debug_aranges,0,-168
.debug_frame,0,-448
.debug_ranges,0,-648
.debug_str,0,-2101
.debug_loc,0,-3661
.debug_abbrev,0,-3707
[Unmapped],0,-3988
.debug_line,0,-9707
.debug_info,0,-40192

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,32
.flash.rodata,-8,-8
.flash.text,-24,-24
.symtab,0,-32
.strtab,0,-96
.debug_aranges,0,-168
.debug_frame,0,-448
.debug_ranges,0,-696
.debug_str,0,-2100
.debug_abbrev,0,-3697
.debug_loc,0,-3970
.debug_line,0,-9668
.debug_info,0,-40005

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize
.debug_loc,0,2
.debug_line,0,-38
.debug_str,0,-218
.debug_info,0,-250

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,32,32
.flash.rodata,-8,-8
.xt.lit._ZNK4chip4SpanIhE7SubSpanEjj,0,-8
.xt.prop._ZNK4chip4SpanIhE7SubSpanEjj,0,-12
[Unmapped],0,-24
.symtab,0,-32
.strtab,0,-96
.debug_aranges,0,-168
.debug_frame,0,-448
.debug_ranges,0,-648
.debug_str,0,-2219
.debug_loc,0,-4019
.debug_abbrev,0,-4195
.debug_line,0,-9853
.debug_info,0,-69630

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,8
.riscv.attributes,0,3
.flash.rodata,-8,-8
.symtab,0,-32
.strtab,0,-96
.debug_aranges,0,-168
.debug_ranges,0,-576
.debug_frame,0,-640
.debug_str,0,-2219
.debug_abbrev,0,-4021
.debug_loc,0,-4447
.debug_line,0,-8612
.debug_info,0,-65492

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,36
.flash.rodata,-8,-8
.flash.text,-28,-28
.symtab,0,-32
.strtab,0,-96
.debug_aranges,0,-168
.debug_frame,0,-448
.debug_ranges,0,-648
.debug_str,0,-2102
.debug_abbrev,0,-3707
.debug_loc,0,-3753
.debug_line,0,-9650
.debug_info,0,-39812


@andy31415 andy31415 merged commit 23ac3c0 into project-chip:master Sep 13, 2021
@bzbarsky-apple bzbarsky-apple deleted the remove-raw-endpoint branch September 13, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants