Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system layer call: add missing brackets #9646

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Sep 13, 2021

Fix master CI build: merge and revert caused a transition from ::SystemLayer to ::SystemLayer() to be missed.

Tested: local build passes after the change.

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Sep 13, 2021
@andy31415 andy31415 merged commit c23f6f4 into project-chip:master Sep 13, 2021
Copy link
Contributor

@mlepage-google mlepage-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this error too, needs this fix.

@mlepage-google
Copy link
Contributor

Weird I don't think I can approve? (I don't see the button.)

@mlepage-google
Copy link
Contributor

Ah I see it's already merged, I just got unlucky with syncing after the break but before the fix.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 0ca8cbd

File Section File VM
chip-ipv6only-app.elf .flash.text 172 172
chip-lock-app.elf .flash.text -60 -60
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,3924
.flash.text,172,172

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,60
.xt.prop._ZNK4chip4SpanIhE7SubSpanEjj,0,12
.xt.lit._ZNK4chip4SpanIhE7SubSpanEjj,0,8
.debug_loc,0,-4
.flash.text,-60,-60

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@andy31415 andy31415 deleted the fix_systemlayer_call branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review linux platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants