Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bugs with notification system: #1408

Merged

Conversation

dhchandw
Copy link
Collaborator

@dhchandw dhchandw commented Aug 21, 2024

  • Duplicate session notifications
  • Number of unseen Notifs don't show up when opening zap
  • Number of seen Notifs don't update when drawer is opened
  • If a session notice is deleted from the database ZAP UI doesn't reflect it correctly in certain cases

Note: there is an sql formatting issue which created a lot of white space diff

@dhchandw dhchandw force-pushed the bug/DuplicateNotifs/GHM_ZAP-448 branch from 41f2617 to c3e6287 Compare August 21, 2024 19:58
@dhchandw dhchandw added bug Something isn't working component: user interface User Interface work only, no backend labels Aug 21, 2024
@dhchandw dhchandw self-assigned this Aug 21, 2024
@dhchandw dhchandw force-pushed the bug/DuplicateNotifs/GHM_ZAP-448 branch from c3e6287 to 35d790f Compare August 21, 2024 20:03
@dhchandw dhchandw requested a review from paulr34 August 21, 2024 20:04
@dhchandw dhchandw force-pushed the bug/DuplicateNotifs/GHM_ZAP-448 branch from 35d790f to 0de046f Compare August 21, 2024 20:10
@dhchandw dhchandw marked this pull request as ready for review August 21, 2024 20:10
Copy link
Collaborator

@tbrkollar tbrkollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tests are passed

@dhchandw dhchandw added this to the ZAPP-1325 milestone Aug 21, 2024
@dhchandw dhchandw linked an issue Aug 21, 2024 that may be closed by this pull request
- Duplicate session notifications
- Number of unseen Notifs don't show up when opening zap
- Number of seen Notifs don't update when drawer is opened
- If a session notice is deleted from the database ZAP UI doesn't reflect this correctly in certain cases
@dhchandw dhchandw force-pushed the bug/DuplicateNotifs/GHM_ZAP-448 branch from 0de046f to ed0801e Compare August 22, 2024 15:07
@dhchandw dhchandw requested a review from brdandu August 22, 2024 15:08
if (this.$serverGet != null) {
this.notis = []
this.getNotificationsAndUpdateSeen()
this.loadPackageNotification(this.packages)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of this.loadPackageNotification(this.packages) intentional? I understood you capturing this.getNotificationsAndUpdateSeen() this change but not loadPackageNotifications. I hope this was not removed by mistake.

@dhchandw dhchandw merged commit efae34c into project-chip:master Aug 22, 2024
13 checks passed
@dhchandw dhchandw deleted the bug/DuplicateNotifs/GHM_ZAP-448 branch August 22, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: user interface User Interface work only, no backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI shows duplicate Session Notifications (at times)
4 participants