-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bugs with notification system: #1408
fixed bugs with notification system: #1408
Conversation
41f2617
to
c3e6287
Compare
c3e6287
to
35d790f
Compare
35d790f
to
0de046f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if tests are passed
- Duplicate session notifications - Number of unseen Notifs don't show up when opening zap - Number of seen Notifs don't update when drawer is opened - If a session notice is deleted from the database ZAP UI doesn't reflect this correctly in certain cases
0de046f
to
ed0801e
Compare
if (this.$serverGet != null) { | ||
this.notis = [] | ||
this.getNotificationsAndUpdateSeen() | ||
this.loadPackageNotification(this.packages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the removal of this.loadPackageNotification(this.packages)
intentional? I understood you capturing this.getNotificationsAndUpdateSeen()
this change but not loadPackageNotifications. I hope this was not removed by mistake.
Note: there is an sql formatting issue which created a lot of white space diff