Add helper to determine the atomic identifier for attribute Id given #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
Oct 31, 2024
brdandu
commented
- as_underlying_atomic_identifier_for_attributeId checks for the attribute type and returns the atomic identifier associated with it.
- JIRA: ZAPP-1385
brdandu
requested review from
tecimovic,
paulr34,
ethanzhouyc,
tbrkollar and
dhchandw
brdandu
force-pushed
the
feature/addHelperToDetermineAtomicIdentifierForAttribute/ZAPP-1385
branch
from
185a42b to
7256090
Compare
- as_underlying_atomic_identifier_for_attributeId checks for the attribute type and returns the atomic identifier associated with it. - JIRA: ZAPP-1385
brdandu
force-pushed
the
feature/addHelperToDetermineAtomicIdentifierForAttribute/ZAPP-1385
branch
from
ab9e179 to
f3bf51a
Compare
tecimovic
approved these changes
Nov 1, 2024
tecimovic
reviewed
Nov 1, 2024
| // If attribute type does not point to atomic type | ||
| let dataType = await queryZcl.selectDataTypeByNameAndClusterId( | ||
| this.global.db, | ||
| attributeDetails.type, |
There was a problem hiding this comment.
This whole block of code is a bit weird.... Mining in all these different places for a name: I can understand where it comes from, but shouldn't there be a better way to do this? Just one table "TYPES" that contains all known types, be it enum values or bitmap values or whatever?
I wonder if having separate tables for these was a mistake...
There was a problem hiding this comment.
All types are in the data_type table but that only has the common characteristics with the distinct attributes of each type going into their corresponding tables.
dhchandw
reviewed
Nov 1, 2024
dhchandw
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.