Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appending session uuid for parent dom #1503

Closed
wants to merge 15 commits into from

Conversation

paulr34
Copy link
Collaborator

@paulr34 paulr34 commented Jan 9, 2025

No description provided.

@paulr34 paulr34 changed the title simplify session_uuid and do not rely on the url bug fix session uuid for parent dom Jan 9, 2025
@paulr34 paulr34 force-pushed the bugFix_sessionuuid_iframe branch from 3462779 to 717d8e0 Compare January 13, 2025 18:30
@paulr34 paulr34 marked this pull request as ready for review January 13, 2025 18:44
Copy link
Collaborator

@tecimovic tecimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes little sense to me..... If you are in a frame with that applicationId, the UUID now never even gets generated. The stsApplicationId doesn't follow the same uniqueness as that, so that is not enough.

THe UUID should ALWAYS be created, it's just that with appId, that has to be appended.

src/boot/axios.js Outdated Show resolved Hide resolved
src/boot/axios.js Outdated Show resolved Hide resolved
src/boot/axios.js Outdated Show resolved Hide resolved
@paulr34 paulr34 requested a review from tecimovic January 14, 2025 16:35
@paulr34 paulr34 changed the title bug fix session uuid for parent dom appending session uuid for parent dom Jan 14, 2025
@paulr34 paulr34 closed this Jan 14, 2025
@paulr34 paulr34 deleted the bugFix_sessionuuid_iframe branch January 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants