Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalidate SQL cache per generation #966

Merged
merged 2 commits into from
Mar 10, 2023
Merged

invalidate SQL cache per generation #966

merged 2 commits into from
Mar 10, 2023

Conversation

jingteng25742
Copy link
Contributor

No description provided.

jiteng added 2 commits March 10, 2023 10:53
when a user changes configurations, such change might have invalidated some configuration specific setting that has been cached already. By flushing the cache, it enables us to cache SQL results without disregarding user inputs.
@codecov-commenter
Copy link

Codecov Report

Merging #966 (e7ae870) into master (2dec018) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   66.24%   66.25%           
=======================================
  Files         155      155           
  Lines       16709    16712    +3     
  Branches     3602     3602           
=======================================
+ Hits        11069    11072    +3     
  Misses       5640     5640           
Impacted Files Coverage Δ
src-electron/generator/generation-engine.js 77.66% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jingteng25742 jingteng25742 merged commit f630679 into project-chip:master Mar 10, 2023
@tecimovic tecimovic mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants