Skip to content

Fix e2e test - invalid go version error #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Mar 22, 2024

Issue link

Issue: https://issues.redhat.com/browse/RHOAIENG-4765

TLDR:

go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240322145600-aeef2b60d6f7): go.mod:3: invalid go version '1.22.0': must match format 1.23

What changes have been made

This PR provided ideas for the fix: KusionStack/kuperator#169

We are currently using the latest version of the mentioned dependency.
This PR is setting it to the latest release that works with our current go version 1.20 until we can upgrade to go1.22

Verification steps

  • e2e tests should pass on this PR.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from astefanutti and dimakis March 22, 2024 16:31
@ChristianZaccaria ChristianZaccaria force-pushed the fix-e2e-go-error branch 5 times, most recently from dc13e85 to 8bd6135 Compare March 25, 2024 10:08
@Fiona-Waters
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2b5d9b8 into project-codeflare:main Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants