Remove owner reference for ClusterRoleBinding to RayCluster #527
Conversation
|
/assign @KPostOffice |
| @@ -232,9 +232,6 @@ func desiredOAuthClusterRoleBinding(cluster *rayv1.RayCluster) *rbacapply.Cluste | |||
| WithAPIGroup("rbac.authorization.k8s.io"). | |||
| WithKind("ClusterRole"). | |||
| WithName("system:auth-delegator"), | |||
| ). | |||
| WithOwnerReferences( | |||
| v1.OwnerReference().WithUID(cluster.UID).WithName(cluster.Name).WithKind(cluster.Kind).WithAPIVersion(cluster.APIVersion), | |||
There was a problem hiding this comment.
In such case controller needs to make sure the CRB is deleted when RayCluster is removed.
There was a problem hiding this comment.
This is achieved with the finalizer. That owner reference isn't relevant as a cluster-scope resource cannot be owned by a namespace resource, which materialises with the absence of the namespace in the reference.
There was a problem hiding this comment.
Right, I completely forgot on that.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
An owner reference from a non-namespaced resource cannot be namespaced.