Skip to content

Conversation

pawelpaszki
Copy link
Contributor

Issue link

What changes have been made

Add various rayjob related tests

Verification steps

oc login ... # to a cluster with RHOAI installed (tested with 2.23)
# install dependencies (if not already installed)
poetry run pytest tests/e2e/rayjob/ -v -s --tb=short # all tests should pass

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from dimakis and kryanbeane August 29, 2025 09:28
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.45%. Comparing base (8b74dbc) to head (398c3f1).
⚠️ Report is 1 commits behind head on ray-jobs-feature.

Additional details and impacted files
@@                Coverage Diff                @@
##           ray-jobs-feature     #893   +/-   ##
=================================================
  Coverage             93.45%   93.45%           
=================================================
  Files                    21       21           
  Lines                  1910     1910           
=================================================
  Hits                   1785     1785           
  Misses                  125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pawel :) Not requesting any changes perse just looking for some clarfification on a couple of things!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2025
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4350b28 into project-codeflare:ray-jobs-feature Aug 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants