Skip to content

Conversation

kryanbeane
Copy link
Contributor

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@kryanbeane
Copy link
Contributor Author

/hold

Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dimakis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2025
@laurafitzgerald laurafitzgerald force-pushed the ray-jobs-feature branch 3 times, most recently from 0a0ad3d to ad304cc Compare October 6, 2025 11:35
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 97.47748% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.04%. Comparing base (e8404ec) to head (219d1c5).

Files with missing lines Patch % Lines
src/codeflare_sdk/common/utils/validation.py 85.71% 5 Missing ⚠️
src/codeflare_sdk/ray/rayjobs/config.py 97.61% 4 Missing ⚠️
src/codeflare_sdk/ray/rayjobs/rayjob.py 98.85% 3 Missing ⚠️
src/codeflare_sdk/ray/cluster/cluster.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   92.47%   94.04%   +1.57%     
==========================================
  Files          25       22       -3     
  Lines        1395     1914     +519     
==========================================
+ Hits         1290     1800     +510     
- Misses        105      114       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants