Skip to content

Allow users to specify instascale configmap namespace #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anishasthana
Copy link
Contributor

No description provided.

asm582
asm582 previously approved these changes Apr 3, 2023
@anishasthana anishasthana force-pushed the fix_instascale_configmap_namespace branch from b461aca to 26ac595 Compare April 3, 2023 21:30
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana anishasthana force-pushed the fix_instascale_configmap_namespace branch from 7ca6e8b to 3f636eb Compare April 3, 2023 22:19
Copy link
Member

@asm582 asm582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@anishasthana anishasthana merged commit 0e39e97 into project-codeflare:main Apr 4, 2023
@anishasthana anishasthana deleted the fix_instascale_configmap_namespace branch April 4, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants