This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Compiler warning fixes #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistent with return types
…se char can be signed in some implementations resulting in a risk of a negative index.
Greg-Griffith
approved these changes
May 12, 2019
Greg-Griffith
added a commit
that referenced
this pull request
May 18, 2019
…identifier to peers (#178) * add initialblockdownload and size_on_disk to getblockchaininfo rpc (#176) * Port rsm version 1.0.1 from upstream (#177) * port rsm 1.0.1 changes from usptream * add rsm lib to build * Compiler warning fixes (#179) * Removed exception specification from function declaration to fix compiler warning. More info - http://www.gotw.ca/publications/mill22.htm * Added explicit [[fallthrough]] for switch statement to suppress compiler warning. * Fixed shadow variable warning * Fixed compiler warnings - shadow variable and two function types inconsistent with return types * Unused variable declaration removed * Fixed compiler warning - using char as array index is dangerous because char can be signed in some implementations resulting in a risk of a negative index. * Compiler warning fixes - shadow variables and unused code removal * Fixed shadow variable warning * Updated fallthrough annotation to C++17 * remove build and build-test folders (#182) * remove versionbits (#181) * remove services folder (#184) * adjust network service versioning for easier use via macros * remove alert message definition, add RREQ, RREP, and RERR * add random key generation for aodv routing to connman * add protocol version for network services, increment procotol version * add nsversion and nsverack message definitions * pass network service information as part of startup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequence of commits fixing various compiler warnings.
Not squashed because I thought it useful for reviewers to see the individual commit comments.