perf: infobox screenshot robustness #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
隐藏所有不属于infobox的元素，而非隐藏预定义的一部分
|
理论上，通过 selector 计算 injectStyles 是否是一个通用的解决方案 |
已提交请求。
应该是的。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
隐藏所有不属于 infobox 的元素，而非隐藏预定义的一部分。
原因
曾经出现 infobox 被某个元素遮挡的情况，如：
48ec5cf 修复了该特例，但对其他情形无效。
此 PR 通过
visibility: hidden隐藏所有infobox外的元素，可以避免未来可能出现的任何遮挡，效果：