-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Introduce asyncio within Ray Actors handling LLMClient #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Since number of ray actors can be limited to a certain amount, it can limit the number of concurrent requests that can be sent to the server.
Fix
To scale up, we have implemented asyncio primitive within each ray actor to handle more requests asynchronously.
Now instead of specifying
--num-concurrent-requests
, we can specify--num-ray-clients
and--num-concurrent-requests-per-client
. This would imply total concurrent requests as product of both ray clients and concurrency factor of each client.Changes Made
OpenAIChatCompletionsClient()
client asynchronously throughhttpx
RequestsManager
which acts as Ray Actor and handles requests asynchronously.RequestsLauncher
to launch multiple instances ofRequestsManager
(equal to--num-ray-clients
)common.py
as it wasn't used.send_llm_request
async across all llm_client files.run_benchmark.py
to work with two-level request scheduling paradigm.run_benchmark
was sending more requests than required, so added additional logic as follows:sent requests < max requests
: send new requestssent requests >= max requests
: send new request only when we got errored requests and didn't handle them. Otherwise keep polling for completed requests.Pending changes