Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking rlimits for new F* #8

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

mtzguido
Copy link
Member

@mtzguido mtzguido commented May 8, 2023

Hi, I needed to bump some rlimits to get an everest green for a change that's coming to F* (FStarLang/FStar@fc1b447, FStarLang/FStar#2894, FStarLang/FStar#2915).

The F* change should be rather innocuous as far as SMT changes go, but some proofs here seem to be close to their rlimit. If these changes don't look too crazy I'd like to merge them so I can merge the F* PR.

@msprotz
Copy link
Member

msprotz commented May 11, 2023

These changes all look good. Two questions:

  • what is assert_spinoff, and why is it helping better than a regular assert? is this a general pattern, should other pieces of Low* code start using assert_spinoff?
  • why is it that a proof needs fuel 4 and ifuel 4? did something regress?
    thanks!

@mtzguido
Copy link
Member Author

Thanks for reviewing!

  • assert_spinoff p is similar to assert, except that the obligation to prove p is done in a separate Z3 query from the "main" one, which can help with stability (e.g. each query has their own rlimit). I am not sure it's actually needed here, I just tend to use it when proofs get hairy. I could try without it, but it also doesn't hurt IMO.
  • I am actually decreasing the fuel, most of the file is under this:
#push-options "--z3rlimit 32 --max_fuel 8 --max_ifuel 8 --initial_fuel 8 --initial_ifuel 8"        

@msprotz
Copy link
Member

msprotz commented May 11, 2023

I am actually decreasing the fuel, most of the file is under this:

😱

assert_spinoff p is similar to assert

thanks for clarifying... this might come in handy in some of the trickier proofs in HACL*

all looks good to me, merging

@msprotz msprotz merged commit 87c0326 into project-everest:master May 11, 2023
@mtzguido mtzguido deleted the guido_2894 branch May 11, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants