Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code comments #139

Merged
merged 3 commits into from
Feb 12, 2020
Merged

add code comments #139

merged 3 commits into from
Feb 12, 2020

Conversation

skothari-tibco
Copy link
Contributor

No description provided.

@abramvandergeest
Copy link
Contributor

I have added Matt and Frank for the review of documents to make sure it is what we are looking for, The issue this is addressing is Issue #62

@abramvandergeest abramvandergeest mentioned this pull request Jan 30, 2020
Copy link
Contributor

@abramvandergeest abramvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Everything that is in it looks good. I think @fm-tibco and @mellistibco should see if they think anything more should be in the documentation. Thanks for doing this Samip!

@@ -8,16 +8,18 @@ import (

type Option func(*action.Config)

//Initiliaize the action.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at https://blog.golang.org/godoc-documenting-go-code. We should probably follow their conventions for the go doc.

It states:

Notice this comment is a complete sentence that begins with the name of the element it describes. This important convention allows us to generate documentation in a variety of formats, from plain text to HTML to UNIX man pages, and makes it read better when tools truncate it for brevity, such as when they extract the first line or sentence.

Copy link
Contributor

@abramvandergeest abramvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skothari-tibco skothari-tibco merged commit 052f2ff into master Feb 12, 2020
@skothari-tibco skothari-tibco deleted the add_comments branch February 12, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants