Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COST-2009 - upgrade to Go 1.16 #118

Merged
merged 1 commit into from
Dec 15, 2021
Merged

COST-2009 - upgrade to Go 1.16 #118

merged 1 commit into from
Dec 15, 2021

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Dec 15, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #118 (5b87443) into main (6d30116) will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   86.78%   87.19%   +0.41%     
==========================================
  Files          10       10              
  Lines        1453     1453              
==========================================
+ Hits         1261     1267       +6     
+ Misses        121      117       -4     
+ Partials       71       69       -2     
Flag Coverage Δ
unittests 87.19% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/kokumetricsconfig_controller.go 77.03% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f861b...5b87443. Read the comment docs.

Copy link
Contributor

@chambridge chambridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@abaiken abaiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too as long as we deploy this to a lab and there are no fires 🔥

@maskarb maskarb changed the title upgrade to Go 1.16 COST-2009 - upgrade to Go 1.16 Dec 15, 2021
@maskarb maskarb merged commit 02f315a into main Dec 15, 2021
@maskarb maskarb deleted the upgrade-go branch December 15, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants