Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and Go version #159

Merged
merged 16 commits into from
Jan 30, 2023
Merged

update dependencies and Go version #159

merged 16 commits into from
Jan 30, 2023

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jan 29, 2023

  • update dependencies
  • update to Go 1.18
  • add loggers at the package level instead of passing a logger thru different structs
  • add outline for a PrometheusRule (currently commented out and unused)

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f567279). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage        ?   87.28%           
=======================================
  Files           ?       10           
  Lines           ?     1439           
  Branches        ?        0           
=======================================
  Hits            ?     1256           
  Misses          ?      116           
  Partials        ?       67           
Flag Coverage Δ
unittests 87.28% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dirconfig/dirconfig.go 95.65% <ø> (ø)
collector/collector.go 88.53% <100.00%> (ø)
collector/prometheus.go 100.00% <100.00%> (ø)
controllers/kokumetricsconfig_controller.go 76.55% <100.00%> (ø)
packaging/packaging.go 81.75% <100.00%> (ø)
sources/handler.go 96.62% <100.00%> (ø)
storage/storage.go 95.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f567279...5d42bcc. Read the comment docs.

@maskarb maskarb changed the title Dep update update dependencies and Go version Jan 30, 2023
@maskarb maskarb self-assigned this Jan 30, 2023
@maskarb maskarb marked this pull request as ready for review January 30, 2023 17:18
@maskarb maskarb requested a review from a team January 30, 2023 17:24
Copy link
Contributor

@chambridge chambridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment about prometheus.go file

controllers/prometheus.go Show resolved Hide resolved
@maskarb maskarb merged commit 300ac4b into main Jan 30, 2023
@maskarb maskarb deleted the dep-update branch January 30, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants