-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies and Go version #159
Conversation
maskarb
commented
Jan 29, 2023
•
edited
Loading
edited
- update dependencies
- update to Go 1.18
- add loggers at the package level instead of passing a logger thru different structs
- add outline for a PrometheusRule (currently commented out and unused)
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage ? 87.28%
=======================================
Files ? 10
Lines ? 1439
Branches ? 0
=======================================
Hits ? 1256
Misses ? 116
Partials ? 67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment about prometheus.go
file