Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-3446] - add Resource Optimization metrics #160

Merged
merged 26 commits into from
Feb 17, 2023
Merged

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jan 30, 2023

  • Add API specs:
    • under PrometheusConfig:
      • DisableMetricsCollectionResourceOptimization <- true by default
      • DisableMetricsCollectionCostManagement <- false by default
  • if DisableMetricsCollectionResourceOptimization is false, collect the ROS metrics and create the ros-openshift-YYYYMM.csv

attached is an example payload.
20230216T191604-cost-mgmt.tar.gz
ROS-report.csv

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #160 (f6a238d) into main (7f41afc) will increase coverage by 0.10%.
The diff coverage is 90.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   88.28%   88.39%   +0.10%     
==========================================
  Files          10       10              
  Lines        1468     1628     +160     
==========================================
+ Hits         1296     1439     +143     
- Misses        103      112       +9     
- Partials       69       77       +8     
Flag Coverage Δ
unittests 88.39% <90.17%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/storage.go 95.50% <ø> (ø)
controllers/kokumetricsconfig_controller.go 80.04% <50.00%> (-0.48%) ⬇️
collector/prometheus.go 96.26% <73.33%> (-3.74%) ⬇️
collector/collector.go 87.87% <87.50%> (-0.66%) ⬇️
collector/types.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f41afc...f6a238d. Read the comment docs.

@maskarb maskarb changed the title [COST-3446] - add Kruize metrics to PrometheusRule [COST-3446] - add Kruize metric Feb 8, 2023
@maskarb maskarb changed the title [COST-3446] - add Kruize metric [COST-3446] - add Resource Optimization metrics Feb 8, 2023
@maskarb maskarb self-assigned this Feb 8, 2023
@maskarb maskarb force-pushed the cost-3446-kruize-metrics branch from cfd5171 to cb4d180 Compare February 8, 2023 19:03
@maskarb maskarb marked this pull request as ready for review February 16, 2023 18:37
@maskarb maskarb requested a review from a team February 16, 2023 18:47
Copy link

@myersCody myersCody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the virtual overview 🙇

@maskarb maskarb merged commit b0dedfa into main Feb 17, 2023
@maskarb maskarb deleted the cost-3446-kruize-metrics branch February 17, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants