Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable reorg and simplification #165

Merged
merged 2 commits into from
Feb 17, 2023
Merged

variable reorg and simplification #165

merged 2 commits into from
Feb 17, 2023

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Feb 17, 2023

This PR builds on #161. Move the prefix koku to the API directory so that it can be imported elsewhere. When we need to change koku to costmanagement, we will only need to update one place instead of many.

@maskarb maskarb self-assigned this Feb 17, 2023
@maskarb maskarb requested a review from a team February 17, 2023 03:08
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #165 (70babc1) into main (36edc8e) will increase coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   87.87%   88.69%   +0.81%     
==========================================
  Files          10       10              
  Lines        1468     1468              
==========================================
+ Hits         1290     1302      +12     
+ Misses        107       99       -8     
+ Partials       71       67       -4     
Flag Coverage Δ
unittests 88.69% <100.00%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dirconfig/dirconfig.go 95.65% <100.00%> (ø)
storage/storage.go 95.50% <100.00%> (ø)
controllers/kokumetricsconfig_controller.go 81.92% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36edc8e...70babc1. Read the comment docs.

Copy link

@myersCody myersCody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maskarb maskarb merged commit 7f41afc into main Feb 17, 2023
@maskarb maskarb deleted the more-koku-removal branch February 17, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants