Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not-configured bug #187

Merged
merged 2 commits into from
Jun 23, 2023
Merged

fix not-configured bug #187

merged 2 commits into from
Jun 23, 2023

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented May 18, 2023

Sometimes the CR status will say that we are not configured against prometheus when we really are. This PR addresses that by ensuring we recheck the PrometheusConfigured and PrometheusConnected statuses if they are false instead of relying on the error messages (ConfigError and ConnectionError).

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #187 (9ced525) into main (2b89d92) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

❗ Current head 9ced525 differs from pull request most recent head d10c191. Consider uploading reports for the commit d10c191 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   88.95%   88.72%   -0.23%     
==========================================
  Files          11       11              
  Lines        2390     2386       -4     
==========================================
- Hits         2126     2117       -9     
- Misses        185      189       +4     
- Partials       79       80       +1     
Flag Coverage Δ
unittests 88.72% <100.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
collector/prometheus.go 96.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b89d92...d10c191. Read the comment docs.

@maskarb maskarb self-assigned this May 18, 2023
@maskarb maskarb requested a review from a team May 18, 2023 19:55
@maskarb maskarb enabled auto-merge (squash) June 23, 2023 20:19
@maskarb maskarb merged commit cb4a24a into main Jun 23, 2023
@maskarb maskarb deleted the use-enum-status branch June 23, 2023 20:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

maskarb added a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants