Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore old default API URL in Spec with new default API URL in Status #194

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Ignore old default API URL in Spec with new default API URL in Status #194

merged 1 commit into from
Jun 23, 2023

Conversation

chambridge
Copy link
Contributor

  • Check spec for old API URL
  • Apply new default API URL

@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #194 (a89ea88) into main (cd0a95e) will increase coverage by 0.35%.
The diff coverage is 100.00%.

❗ Current head a89ea88 differs from pull request most recent head 20638a6. Consider uploading reports for the commit 20638a6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   88.72%   89.07%   +0.35%     
==========================================
  Files          11       11              
  Lines        2385     2390       +5     
==========================================
+ Hits         2116     2129      +13     
+ Misses        189      183       -6     
+ Partials       80       78       -2
Flag Coverage Δ
unittests 89.07% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/kokumetricsconfig_controller.go 84.91% <100.00%> (+1.49%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0a95e...20638a6. Read the comment docs.

@chambridge chambridge force-pushed the overwrite-old-default-api-url branch from b667b56 to 974ee41 Compare June 23, 2023 19:19
@chambridge chambridge requested a review from maskarb June 23, 2023 19:25
@chambridge chambridge marked this pull request as ready for review June 23, 2023 19:25
maskarb
maskarb reviewed Jun 23, 2023
View reviewed changes
controllers/kokumetricsconfig_controller_test.go Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@chambridge
Ignore old default API URL in Spec with new default API URL in Status
20638a6 
* Check spec for old API URL
* Apply new default API URL
@chambridge chambridge force-pushed the overwrite-old-default-api-url branch from a89ea88 to 20638a6 Compare June 23, 2023 20:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@chambridge chambridge requested a review from maskarb June 23, 2023 20:14
maskarb
maskarb approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@maskarb maskarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chambridge chambridge merged commit 2b89d92 into main Jun 23, 2023
@chambridge chambridge deleted the overwrite-old-default-api-url branch June 23, 2023 20:15
maskarb pushed a commit that referenced this pull request Sep 8, 2023
@chambridge @maskarb
Ignore old default API URL in Spec with new default API URL in Status (…
71dbe19 
…#194)

* Check spec for old API URL
* Apply new default API URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maskarb maskarb maskarb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chambridge @maskarb