[COST-4080] Replace default source name with cluster-uuid if CR is not updated #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 89.17% 89.19% +0.01%
==========================================
Files 11 11
Lines 2457 2461 +4
==========================================
+ Hits 2191 2195 +4
Misses 187 187
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
update unit test use empty str vs null
…into cost-4080-default-src-name
|
Kudos, SonarCloud Quality Gate passed! |
maskarb
pushed a commit
that referenced
this pull request
Sep 8, 2023
…t updated (#196) * use cluster id as default source name * replace default source name after cluster id is obtained update unit test use empty str vs null * update doc * add existing source name to error msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4080
Description
INSERT-SOURCE-NAMEin the spec source name field.