Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4230] make spec.authentication.token_url optional #238

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

djnakabaale
Copy link
Contributor

  • Make spec.authentication.token_url optional to avoid error below during operator upgrade
error validating existing CRs against new CRD's schema for "kokumetricsconfigs.koku-metrics-cfg.openshift.io": error validating custom resource against new schema for KokuMetricsConfig koku-metrics-operator/kokumetricscfg-sample-v1beta1: [].spec.authentication.token_url: Required value

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #238 (cff48bb) into main (3b413d3) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   85.18%   85.07%   -0.12%     
==========================================
  Files          13       13              
  Lines        2720     2720              
==========================================
- Hits         2317     2314       -3     
- Misses        324      325       +1     
- Partials       79       81       +2     
Flag Coverage Δ
unittests 85.07% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/kokumetricsconfig_controller.go 85.77% <100.00%> (-0.45%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b413d3...cff48bb. Read the comment docs.

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@djnakabaale djnakabaale merged commit fc5aee5 into main Dec 1, 2023
8 checks passed
@djnakabaale djnakabaale deleted the cost-4230-add-sa-auth-bugfix branch December 1, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants