Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4866] add csi_driver and csi_volume_handle to storage reports #335

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Apr 18, 2024

  • add csi_driver and csi_volume_handle to storage reports

I did not add a full set of data for the second volume in the example report, but I included enough to show what happens when the csi_driver and csi_volume_handle do not exist in the metrics: they go into the report as a blank entry.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.12%. Comparing base (87f86f7) to head (0f2f340).
Report is 1 commits behind head on main.

❗ Current head 0f2f340 differs from pull request most recent head c7c60e6. Consider uploading reports for the commit c7c60e6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   86.09%   86.12%   +0.02%     
==========================================
  Files          13       13              
  Lines        2165     2169       +4     
==========================================
+ Hits         1864     1868       +4     
  Misses        220      220              
  Partials       81       81              
Flag Coverage Δ
unittests 86.12% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/collector/types.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb3b7fe...c7c60e6. Read the comment docs.

@maskarb maskarb enabled auto-merge (squash) April 19, 2024 13:34
@maskarb maskarb merged commit af9ff74 into main Apr 19, 2024
8 checks passed
@maskarb maskarb deleted the COST-4866-csi-data branch April 19, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants