Update pre-commit hook golangci/golangci-lint to v1.61.0

[red-hat-konflux]

This PR contains the following updates:

Package	Type	Update	Change
golangci/golangci-lint	repository	minor	v1.54.2 -> v1.61.0

Note: The pre-commit manager in Renovate is not supported by the pre-commit maintainers or community. Please do not report any problems there, instead create a Discussion in the Renovate repository if you have any questions.

---

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v1.61.0

Compare Source

1. Enhancements
   • Add junit-xml-extended format
   • Exclude Swagger Codegen files by default
2. Updated linters
   • dupword: from 0.0.14 to 0.1.1
   • fatcontext: from 0.4.0 to 0.5.2
   • gci: from 0.13.4 to 0.13.5 (new option no-lex-order)
   • go-ruleguard: from 0.4.2 to 0fe6f58 (fix panic with custom linters)
   • godot: from 1.4.16 to 1.4.17
   • gomodguard: from 1.3.3 to 1.3.5
   • gosec: disable temporarily G407
   • gosec: from ab3f6c1 to 2.21.2 (partially fix G115)
   • intrange: from 0.1.2 to 0.2.0
   • nolintlint: remove the empty line in the directive replacement
3. Misc.
   • Improve runtime version parsing
4. Documentation
   • Add additional info about typecheck

v1.60.3

Compare Source

1. Updated linters
   • gosec: from 81cda2f to ab3f6c1 (fix G115 false positives)
2. Misc.
   • Check that the Go version use to build is greater or equals to the Go version of the project

v1.60.2

Compare Source

1. Updated linters

• gofmt: update to HEAD (go1.22)
• gofumpt: from 0.6.0 to 0.7.0
• gosec: fix G602 analyzer
• gosec: from 5f0084e to 81cda2f (adds G115, G405, G406, G506, G507)
• staticcheck: from 0.5.0 to 0.5.1
• staticcheck: propagate Go version
• wrapcheck: from 2.8.3 to 2.9.0
• ⚠️ exportloopref: deprecation

v1.60.1

Compare Source

1. Updated linters
   • errorlint: from 1.5.2 to 1.6.0
   • exhaustruct: from 3.2.0 to 3.3.0 (recognize custom error values in return)
   • fatcontext: from 0.2.2 to 0.4.0 (fix false positives for context stored in structs)
   • gocognit: from 1.1.2 to 1.1.3
   • gomodguard: from 1.3.2 to 1.3.3
   • govet (printf): report non-constant format, no args
   • lll: advertise max line length instead of just reporting failure
   • revive: from 1.3.7 to 1.3.9 (new rule: comments-density)
   • sloglint: from 0.7.1 to 0.7.2
   • spancheck: from 0.6.1 to 0.6.2
   • staticcheck: from 0.4.7 to 0.5.0
   • tenv: from 1.7.1 to 1.10.0 (remove reports on fuzzing)
   • testifylint: from 1.3.1 to 1.4.3 (new options: formatter, suite-broken-parallel, suite-subtest-run)
   • tparallel: from 0.3.1 to 0.3.2
   • usestdlibvars: from 1.26.0 to 1.27.0 (fix false-positive with number used inside a mathematical operations)
   • wsl: from 4.2.1 to 4.4.1
   • ️⚠️ unused: remove exported-is-used option
2. Fixes
   • SARIF: sanitize level property
   • ️⚠️ typecheck issues should never be ignored
3. Documentation
   • Add link on linter without configuration
   • Remove 'trusted by' page
   • wsl update documentation of the configuration
4. misc.
   • 🎉 go1.23 support

v1.60.0

Compare Source

Cancelled due to a CI problem.

v1.59.1

Compare Source

1. Updated linters
   • errorlint: from 1.5.1 to 1.5.2
   • gomnd: deprecated configuration compatibility
   • intrange: add style preset
   • misspell: from 0.5.1 to 0.6.0
   • sloglint: from 0.7.0 to 0.7.1
   • testifylint: from 1.3.0 to 1.3.1
   • unparam: bump to HEAD
   • usestdlibvars: from 1.25.0 to 1.26.0
2. Fixes
   • SARIF: init empty result slice
   • SARIF: issue column >= 1
3. Documentation
   • revive: update documentation of the configuration

v1.59.0

Compare Source

1. Enhancements
   • Add SARIF output format
   • Allow the analysis of generated files (issues.exclude-generated: disable)
2. Updated linters
   • errcheck: fix deprecation warning
   • go-critic: from 0.11.3 to 0.11.4
   • gosec: from 2.20.0 to 5f0084e (fix G601 and G113 performance issues)
   • sloglint: from 0.6.0 to 0.7.0 (new option forbidden-keys)
   • testifylint: from 1.2.0 to 1.3.0 (new checker negative-positive and new option go-require.ignore-http-handlers)
3. Misc.
   • ️️⚠️ Deprecate github-action output format
   • ️️⚠️ Deprecate issues.exclude-generated-strict option (replaced by issues.exclude-generated: strict)
   • ️️⚠️ Add warning about disabled and deprecated linters (level 2)

v1.58.2

Compare Source

1. Updated linters
   • canonicalheader: from 1.0.6 to 1.1.1
   • gosec: from 2.19.0 to 2.20.0
   • musttag: from 0.12.1 to 0.12.2
   • nilnil: from 0.1.8 to 0.1.9
2. Documentation
   • Improve integrations and install pages

v1.58.1

Compare Source

1. Updated linters
   • tagalign: from 1.3.3 to 1.3.4
   • protogetter: from 0.3.5 to 0.3.6
   • gochecknoinits: fix analyzer name
2. Fixes
   • Restores previous gihub-actions output format (removes GitHub Action problem matchers)

v1.58.0

Compare Source

1. New linters
   • fatcontext: https://github.com/Crocmagnon/fatcontext
   • canonicalheader: https://github.com/lasiar/canonicalheader
2. Updated linters
   • copyloopvar: from 1.0.10 to 1.1.0 (ignore-alias is replaced by check-alias with the opposite behavior)
   • decorder: from 0.4.1 to 0.4.2
   • errname: from 0.1.12 to 0.1.13
   • errorlint: from 1.4.8 to 1.5.1 (new options allowed-errors and allowed-errors-wildcard)
   • execinquery: deprecate linter ⚠️
   • gci: from 0.12.3 to 0.13.4 (new section localModule)
   • gocritic: from 0.11.2 to 0.11.3
   • spancheck: from 0.5.3 to 0.6.1
   • goerr113 is replaced by err113 ⚠️
   • gomnd is replaced by mnd ⚠️
   • gomodguard: from 1.3.1 to 1.3.2
   • grouper: from 1.1.1 to 1.1.2
   • intrange: from 0.1.1 to 0.1.2
   • mirror: from 1.1.0 to 1.2.0
   • misspell: from 0.4.1 to 0.5.1
   • musttag: from 0.9.0 to 0.12.1
   • nilnil: from 0.1.7 to 0.1.8
   • nonamedreturns: from 1.0.4 to 1.0.5
   • promlinter: from 0.2.0 to 0.3.0
   • sloglint: from 0.5.0 to 0.6.0
   • unparam: bump to HEAD (063aff9)
   • whitespace: from 0.1.0 to 0.1.1
3. Enhancements
   • Speed up "fast" linters when only "fast" linters are run: between 40% and 80% faster at first run (i.e. without cache)
4. Fixes
   • Use version with module plugins
   • Skip go.mod report inside autogenerated processor
   • Keep only typecheck issues when needed
   • Don't hide typecheck errors inside diff processor
5. Misc.
   • ⚠️ log an error when using previously deprecated linters (Linter Deprecation Cycle)
     • deadcode: deprecated since v1.49.0 (2022-08-23).
     • exhaustivestruct: deprecated since v1.46.0 (2022-05-08).
     • golint: deprecated since v1.41.0 (2021-06-15).
     • ifshort: deprecated since v1.48.0 (2022-08-04).
     • interfacer: deprecated since v1.38.0 (2021-03-03).
     • maligned: deprecated since v1.38.0 (2021-03-03).
     • nosnakecase: deprecated since v1.48.0 (2022-08-04).
     • scopelint: deprecated since v1.39.0 (2021-03-25).
     • structcheck: deprecated since v1.49.0 (2022-08-23).
     • varcheck: deprecated since v1.49.0 (2022-08-23).
   • ⚠️ Deprecate usage of linter alternative names
   • Remove help display on errors with config verify command
   • Add pre-commit hook to run config verify
   • Improve github-action output
6. Documentation
   • Remove deprecated Atom from Editor Integrations

GitHub Action (v5.1.0) for golangci-lint:

• supports for pull, pull_request_target, and merge_group events with the option only-new-issues.
• ️️⚠️ skip-pkg-cache and skip-build-cache have been removed because the cache related to Go itself is already handled by actions/setup-go.
• with golangci-lint v1.58, the file information (path and position) will be displayed on the log.

v1.57.2

Compare Source

1. Updated linters
   • contextcheck: from 1.1.4 to 1.1.5
   • copyloopvar: from 1.0.8 to 1.0.10
   • ginkgolinter: from 0.16.1 to 0.16.2
   • goconst: from 1.7.0 to 1.7.1
   • gomoddirectives: from 0.2.3 to 0.2.4
   • intrange: from 0.1.0 to 0.1.1
2. Misc.
   • Display warnings on deprecated linter options
   • Fix missing colored-tab output format
   • Fix TeamCity inspectionType service message
3. Documentation
   • Remove invalid example about mixing files and directory
   • Improve linters page

v1.57.1

Compare Source

1. Fixes
   • Ignore issues with invalid position (e.g. contextcheck).

v1.57.0

Compare Source

1. New linters
   • copyloopvar: https://github.com/karamaru-alpha/copyloopvar
   • intrange: https://github.com/ckaznocha/intrange
2. Updated linters
   • dupword: from 0.0.13 to 0.0.14
   • gci: from 0.12.1 to 0.12.3
   • ginkgolinter: from 0.15.2 to 0.16.1 (new option force-expect-to, validate-async-intervals, and forbid-spec-pollution)
   • go-critic: from 0.11.1 to 0.11.2
   • go-critic: support of enable-all and disable-all options
   • go-spancheck: from 0.5.2 to 0.5.3
   • gomodguard: from 1.3.0 to 1.3.1
   • govet: deprecation of check-shadowing ⚠️
   • govet: disable temporarily httpresponse because of a bug https://github.com/golang/go/issues/66259
   • misspell: add extra-words
   • musttag: from 0.8.0 to 0.9.0
   • nakedret: from 2.0.2 to 2.0.4
   • paralleltest: from 1.0.9 to 1.0.10
   • perfsprint: from 0.6.0 to 0.7.1 (new option strconcat)
   • protogetter: from 0.3.4 to 0.3.5
   • revive: add exclude option
   • sloglint: from 0.4.0 to 0.5.0 (new option no-global)
   • staticcheck: from 0.4.6 to 0.4.7
   • testifylint: from 1.1.2 to 1.2.0 (new option bool-compare)
   • unconvert: to HEAD (new options fast-math and safe)
   • wrapcheck: from 2.8.1 to 2.8.3
   • Disable copyloopvar and intrange on Go < 1.22
3. Enhancements
   • 🧩New custom linters system https://golangci-lint.run/plugins/module-plugins/
   • Allow running only a specific linter without modifying the file configuration (--enable-only)
   • Allow custom sort order for the reports (output.sort-order)
   • Automatically adjust the maximum concurrency to the container CPU quota if run.concurrency=0
   • Add config verify command to check the configuration against the JSON Schema
   • Option to strictly follow Go generated file convention (issues.exclude-generated-strict)
   • Syntax to not override severity from linters (@linter)
   • Use severities from gosec
   • Create automatically directory related to output.formats.path
   • Use the first issue without inline on mergeLineIssues on multiple issues
4. Misc.
   • ⚠️ Inactivate deprecated linters (deadcode, exhaustivestruct, golint, ifshort, interfacer, maligned, nosnakecase, scopelint, structcheck, varcheck)
   • ⚠️ Deprecated CLI flags have been removed (deprecated since 2018)
   • ⚠️ Move show-stats option from run to output configuration section
   • ⚠️ Replace run.skip-xxx options by issues.exclude-xxx options
   • ⚠️ Replace output.format by output.formats with a new file configuration syntax
   • Internal rewrite of the CLI
   • Improve 'no go files to analyze' message
   • Use GOTOOLCHAIN=auto inside the Docker images
5. Documentation
   • ⚠️ Define the linter deprecation cycle https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle
   • 🎉Use information from the previous release to create linter pages
   • Publish JSON schema on https://golangci-lint.run/jsonschema/golangci.jsonschema.json
   • Reorganize documentation pages
   • Add an explanation about the configuration file inside golangci-lint repository

⚠️ Important ⚠️

1. Deprecated linters are inactivated, you still need to disable them if you are using enable-all.
2. Deprecated CLI flags (about linter settings and deadline) have been removed.

v1.56.2

Compare Source

1. updated linters
   • go-critic: from 0.11.0 to 0.11.1
   • gosec: from 2.18.2 to 2.19.0
   • testifylint: from 1.1.1 to 1.1.2
   • usestdlibvars: from 1.24.0 to 1.25.0
   • wsl: from 4.2.0 to 4.2.1
2. misc.
   • Fix missing version in Docker image
3. Documentation
   • Explain the limitation of new-from-rev and new-from-patch

v1.56.1

Compare Source

1. updated linters
   • errcheck: from 1.6.3 to 1.7.0
   • govet: disable loopclosure with go1.22
   • revive: from 1.3.6 to 1.3.7
   • testifylint: from 1.1.0 to 1.1.1

v1.56.0

Compare Source

1. new linters
   • spancheck: https://github.com/jjti/go-spancheck
2. updated linters
   • depguard: from 2.1.0 to 2.2.0
   • exhaustive: from 0.11.0 to 0.12.0
   • exhaustruct: from 3.1.0 to 3.2.0
   • gci: from 0.11.2 to 0.12.1
   • ginkgolinter: from 0.14.1 to 0.15.2
   • go-check-sumtype: from 0.1.3 to 0.1.4
   • go-critic: from 0.9.0 to 0.11.0
   • go-errorlint: from 1.4.5 to 1.4.8
   • go-spancheck: from 0.4.2 to 0.5.2
   • goconst: from 1.6.0 to 1.7.0
   • godot: from 1.4.15 to 1.4.16
   • gofumpt: from 0.5.0 to 0.6.0
   • inamedparam: from 0.1.2 to 0.1.3
   • ineffassign: from 0.0.0-20230610083614-0e73809eb601 to 0.1.0
   • ireturn: from 0.2.2 to 0.3.0
   • misspell: add mode option
   • musttag: from v0.7.2 to v0.8.0
   • paralleltest: from 1.0.8 to 1.0.9
   • perfsprint: from 0.2.0 to 0.6.0
   • protogetter: from 0.2.3 to 0.3.4
   • revive: from 1.3.4 to 1.3.6
   • sloglint: add static-msg option
   • sloglint: from 0.1.2 to 0.4.0
   • testifylint: from 0.2.3 to 1.1.0
   • unparam: from 2022122-7455f1af531d to 2024010-c549a3470d14
   • whitespace: update after moving to the analysis package
   • wsl: from 3.4.0 to 4.2.0
   • zerologlint: from 0.1.3 to 0.1.5
3. misc.
   • 🎉 go1.22 support
   • Implement stats per linter with a flag
   • Make versioning inside Docker image consistent with binaries
   • Parse Go RC version
4. Documentation
   • Fix noctx description
   • Add missing fields to .golangci.reference.yml
   • Improve .golangci.reference.yml defaults
   • typecheck: improve FAQ
   • exhaustruct: note that struct regular expressions are expected to match the entire package/name/structname
   • wrapcheck: adjust ignoreSigs to new defaults

Important

testifylint has breaking changes about enabling/disabling checks:

• If you were using the option enable with a filtered list of checks, you should either add disable-all: true (1) or use disable field (2).

Example (1)

  testifylint:
    disable-all: true
    enable:
      - bool-compare
      - compares
      - empty
      - error-is-as
      - error-nil
      - expected-actual
      - go-require
      - float-compare
      - len
      - nil-compare
      - require-error

- suite-dont-use-pkg

      - suite-extra-assert-call
      - suite-thelper
```

```yml

Example (2)

  testifylint:
    disable:
      - suite-dont-use-pkg
```

v1.55.2

Compare Source

1. updated linters
   • ireturn: from 0.2.1 to 0.2.2
   • ginkgolinter: from 0.14.0 to 0.14.1

v1.55.1

Compare Source

1. updated linters
   • gosec: from 2.18.1 to 2.18.2
2. misc.
   • revgrep: from v0.5.0 to v0.5.2 (support git < 2.41.0)
   • output: convert backslashes to forward slashes for GitHub Action annotations printer

v1.55.0

Compare Source

1. new linters
   • gochecksumtype: https://github.com/alecthomas/go-check-sumtype
   • inamedparam: https://github.com/macabu/inamedparam
   • perfsprint: https://github.com/catenacyber/perfsprint
   • protogetter: https://github.com/ghostiam/protogetter
   • sloglint: https://github.com/go-simpler/sloglint
   • testifylint: https://github.com/Antonboom/testifylint
2. updated linters
   • bidichk: from 0.2.4 to 0.2.7
   • decorder: from 0.4.0 to 0.4.1
   • dupword: from 0.0.12 to 0.0.13
   • errchkjson: from 0.3.1 to 0.3.6
   • gci: from 0.11.0 to 0.11.2
   • ginkgolinter: from 0.13.5 to 0.14.0
   • go-errorlint: from 1.4.4 to 1.4.5
   • gocognit: from 1.0.7 to 1.1.0
   • goconst: from 1.5.1 to 1.6.0
   • godot: from 1.4.14 to 1.4.15
   • gofmt: update to HEAD
   • goimports: update to HEAD
   • gosec: from 2.17.0 to 2.18.1
   • gosmopolitan: from 1.2.1 to 1.2.2
   • govet: add appends analyzer
   • ireturn: from 0.2.0 to 0.2.1
   • protogetter: from 0.2.2 to 0.2.3
   • revgrep: from 745bb2f to v0.5.0
   • revive: from 1.3.2 to 1.3.4
   • sqlclosecheck: from 0.4.0 to 0.5.1
   • staticcheck: from 0.4.5 to 0.4.6
   • tagalign: from 1.3.2 to 1.3.3
   • unused: support passing in options
3. misc.
   • Add a pre-commit hook to check all files
4. Documentation
   • add source options to exclude-rules docs
   • gosec: add G602 to includes/excludes inside .golangci.reference.yml

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (3fbb815) to head (5548d73).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files          22       22           
  Lines        2729     2729           
=======================================
  Hits         2193     2193           
  Misses        434      434           
  Partials      102      102           

Flag	Coverage Δ
unittests	80.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbb815...5548d73. Read the comment docs.

[djnakabaale]

/ok-to-test

[djnakabaale]

/ok-to-test

[djnakabaale]

/retest