Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge downstream v3 #447

Merged
merged 20 commits into from
Sep 27, 2024
Merged

Merge downstream v3 #447

merged 20 commits into from
Sep 27, 2024

Conversation

djnakabaale
Copy link
Contributor

No description provided.

maskarb and others added 17 commits May 31, 2024 09:58
* update license badge

* clean up badges

* remove license badge
* [COST-5377] update whats new in 3.3.1

* fix typo
* make bundle for v3.3.1 (#389)

* [COST-5390] make downstream v3.3.1

* clean up directory name and version
* make bundle for v3.3.1 (#389)

* [COST-5390] make downstream v3.3.1

* clean up directory name and version

* [COST-5409] Specify correct toolchain version number in go.mod (#394)

* [COST-5409] Specify correct toolchain version number in go.mod

* use mirco version

* definitely use toolchain and not micro version

* address non-constant format string in call to fmt.Errorf
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (8c10aa0) to head (1a80e81).
Report is 1 commits behind head on downstream.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           downstream     #447      +/-   ##
==============================================
- Coverage       85.90%   80.13%   -5.77%     
==============================================
  Files              13       22       +9     
  Lines            2206     2729     +523     
==============================================
+ Hits             1895     2187     +292     
- Misses            226      438     +212     
- Partials           85      104      +19     
Flag Coverage Δ
unittests 80.13% <100.00%> (-5.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nternal/controller/kokumetricsconfig_controller.go 84.40% <100.00%> (+0.03%) ⬆️
internal/packaging/packaging.go 83.33% <100.00%> (+0.82%) ⬆️
internal/sources/handler.go 96.84% <100.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c10aa0...1a80e81. Read the comment docs.

@djnakabaale djnakabaale marked this pull request as ready for review September 27, 2024 19:45
@djnakabaale djnakabaale merged commit 21e15a4 into downstream Sep 27, 2024
10 checks passed
@djnakabaale djnakabaale deleted the merge-downstream-v3 branch September 27, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants