Switch to Monai Bundle config

[ibro45]

Closes #7.

Still needs to be addressed:

• Monai Bundle Config doesn't support defining functions/methods using _target_ (opened an issue Parse callables (functions, methods) similarly to objects Project-MONAI/MONAI#5852 ) so I had to find a workaround. This enables passing the cli arguments to the Trainer method that you're running, e.g. --fit#ckpt_path <PATH>:

  lighter/lighter/cli.py

  Line 17 in 0e26608

  fit_config = yaml.safe_load("""

• Import project as a module does not work currently

Note:

• Calling lighter fit --config_file ... is basically equal to python -m monai.bundle run fit --config_file ....

Conclusion:

• The configs remain basically the same apart from different referencing between Monai Bundle and Hydra/OmegaConf https://github.com/project-lighter/lighter/blob/monai-bundle/projects/cifar10/experiments/monai_bundle_prototype.yaml
• Allowed us to get rid of the runner and config modules

[ibro45]

@surajpaib Cannot seem to make the user project import work, even though the same implementation worked before monai bundle config

[surajpaib]

I think I understand what the issue is, the project function is only instantiated, but never called

[surajpaib]

Here is a working solution for your previous approach

project:
    _target_: lighter.utils.import_module_from_path
    module_name: project
    module_path: ./projects/cifar10

trainer:
    _target_: pytorch_lightning.Trainer
    max_epochs: 50
    accelerator: gpu
    devices: 1

system:
    _target_: lighter.LighterSystem
    batch_size: 512
    pin_memory: True
    num_workers: 4
    log_input_as: "image_batch"

    model:
        _target_: project.models.net.Net
        _requires_: "$@project()"

[surajpaib]

@ibro45 I'm thinking of a better way to do this overall, will post when I have an update

[ibro45]

Sorry, didn't see your comments. So, in the meantime i realized we don't need the import project. That makes it a bit better. In your example I have to say that I don't like having to call the partial function like _requires_: "$@project()". Actually, I've been confused by why they didn't implement it so that it's called whenever you refer it, without all the $ and (). Let's see what happens with that PR they opened, I'll suggest it if they don't end up doing it.

[surajpaib]

I get why they did it this way though because you want a reference to the function and not call the function itself in many cases. And then be able to call it into your code however you want.

For example. if you defined a train, test and val functions, and then want to call them accordingly.
I think its difficult to achieve both functionality together though :(

[ibro45]

Managed to get it to behave as it did before monai bundle config. Ready to be merged if you agree.

[surajpaib]

Amazing stuff with monai-bundle! Looks good to go, added a comment about a small refactor, let me know if you think it makes sense and I can add a commit to the PR

[surajpaib]

Looks good to go from me!