linux/udev: fix udevadm info parser to not be fatal #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 65.78% 65.38% -0.40%
==========================================
Files 17 17
Lines 2531 2551 +20
==========================================
+ Hits 1665 1668 +3
- Misses 667 683 +16
- Partials 199 200 +1 ☔ View full report in Codecov by Sentry. |
mikemccracken
approved these changes
Feb 16, 2024
hallyn
reviewed
Feb 16, 2024
raharper
force-pushed
the
fix/linux-udevadm-parsing
branch
2 times, most recently
from
3c5810f to
b0f7b9a
Compare
The current parser returns an error when it encounters newer prefix values in the output of udevadm info. Anytime a system upgrades to a newer release, there is a change new fields will be present preventing disko from producing any output. - Update and document prefixes defined in systemd v255 - Replace error with an warning output - make sure we have two tokens when parsing udevadm info output Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
raharper
force-pushed
the
fix/linux-udevadm-parsing
branch
from
b0f7b9a to
0ef4318
Compare
hallyn
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current parser returns an error when it encounters newer prefix values in the output of udevadm info. Anytime a system upgrades to a newer release, there is a change new fields will be present preventing disko from producing any output.