Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with vincentlanglet/twig-cs-fixer > 2.0.0 #4

Closed
ynnoig opened this issue Feb 9, 2024 · 2 comments · Fixed by #5
Closed

Incompatible with vincentlanglet/twig-cs-fixer > 2.0.0 #4

ynnoig opened this issue Feb 9, 2024 · 2 comments · Fixed by #5
Assignees
@athopen
Labels
bug Something isn't working

Comments

@ynnoig
Copy link

ynnoig commented Feb 9, 2024

ArgumentCountError - Too few arguments to function TwigCsFixer\Report\Reporter\TextReporter::display(), 3 passed in /home/project/actions-runner/_work/project/vendor/project-nos/spryker-twig-code-sniffer/src/Nos/Shared/TwigCodeSniffer/Runner/Runner.php on line 137 and exactly 4 expected in ...vendor/vincentlanglet/twig-cs-fixer/src/Report/Reporter/TextReporter.php::26

The fourth parameter was introduced in version 2.1.0 (VincentLanglet/Twig-CS-Fixer@2.0.0...2.1.0)
@athopen
Copy link
Contributor

athopen commented Feb 11, 2024

Thanks @ynnoig for your issue report. I will create a new Release ASAP and lock the version to 2.0.

@athopen athopen self-assigned this Feb 12, 2024
@athopen athopen added the bug Something isn't working label Feb 12, 2024
athopen added a commit that referenced this issue Feb 12, 2024
@athopen
#4 lock package vincentlanglet/twig-cs-fixer to 2.0.*
96c1980
@athopen athopen linked a pull request Feb 12, 2024 that will close this issue
#4 lock package vincentlanglet/twig-cs-fixer to 2.0.* #5
Merged
athopen added a commit that referenced this issue Feb 12, 2024
@athopen
Merge pull request #5 from project-nos/4-incompatible-with-vincentlan…
5234dec 
…glettwig-cs-fixer-200

#4 lock package vincentlanglet/twig-cs-fixer to 2.0.*
@athopen
Copy link
Contributor

athopen commented Feb 12, 2024

@ynnoig i locked the version to 2.0.x in the newest release -> https://packagist.org/packages/project-nos/spryker-twig-code-sniffer#v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athopen athopen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4 lock package vincentlanglet/twig-cs-fixer to 2.0.* project-nos/spryker-twig-code-sniffer
2 participants
@athopen @ynnoig