Skip to content

Commit

Permalink
Remove invalid test runner variation in the UEFI app (#2725)
Browse files Browse the repository at this point in the history
This config does not behave as intended, as (somewhat counterintuitively) cfg in the config does not have access to all the usual values, including features or in this case test.

See the tracking cargo rust-lang/cargo#8170
  • Loading branch information
jul-sh authored Apr 14, 2022
1 parent adcd685 commit 0bc8168
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions experimental/uefi/app/.cargo/config.toml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
[build]
target = "x86_64-unknown-uefi"

# Test runners get only one serial port, routed to stdio.
[target.'cfg(test)']
runner = "qemu-system-x86_64 -nodefaults -nographic -bios /usr/share/OVMF/OVMF_CODE.fd -serial stdio -machine q35 -device isa-debug-exit,iobase=0xf4,iosize=0x04 -kernel"

# Otherwise, (a) the first serial port gets routed to a log, and (b) the second serial gets attached to stdio.
[target.'cfg(not(test))']
[target.x86_64-unknown-uefi]
runner = "qemu-system-x86_64 -nodefaults -nographic -bios /usr/share/OVMF/OVMF_CODE.fd -serial file:target/console.log -serial stdio -machine q35 -device isa-debug-exit,iobase=0xf4,iosize=0x04 -kernel"

[unstable]
Expand Down

0 comments on commit 0bc8168

Please sign in to comment.