-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build.yml #41
Update build.yml #41
Conversation
.github/workflows/build.yml
Outdated
west build --pristine -b b_u585i_iot02a ./application -d build -- -DMODULE_EXT_ROOT=$(pwd)/application | ||
|
||
# Flash to the board | ||
west flash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this GHA workflow really have connectivity to the board? I can understand building the Ocre runtime for the target board, but maybe not flashing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @johnwalicki , that was the idea. We wanted to fully validate a handful of boards (5-10) at some point. But to your point it could be a bit of overkill to flash.
what are your main concerns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment was that west flash
in a GitHub action is going to fail because it doesn't have access to the physical board. The build / first parts will likely success but then the flash will fail, so the workflow will be marked as a fail.
Okay that makes sense, yeah the physical board is connected as this is our self hosted (physical) runner llocated in the UNH-IOL. The build failed because STM32 CubeProgrammer isn’t installed, but I already instructed @PatrickRobbIOL how to do so. The box should be configured soon and the build will pass. |
Added conditional logic for physical-host only to flash boards.
Added debugging
updating
added flash
I added a step to build and flash the ST b_u585i_iot02 board upon success of building the native_sim. This lays the groundwork for unit testing, container lifecycle validation, more board support, etc.