Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar: add ❌ button to clear the search terms; emit actions upon user input. #214

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

tyreseluo
Copy link
Contributor

@tyreseluo tyreseluo commented Oct 27, 2024

Partially addresses #123.

Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by a few things in this PR.

  1. What is the purpose of this PR? there's no description, and the title is lengthy but not quite detailed enough.
  2. As a follow-up to the above, this doesn't seem to actually implement the search functionality. So it'd be pretty confusing for users to see a new search bar that they can interact with but doesn't actually do anything.... unless there is another PR that is designed as a pairing to this?
  3. The search timer idea is unusual, to say the least. The action of searching should happen automatically upon typing (i.e., when the typed text changes), which you can determine by checking for actions on the actual TextInput widget.

resources/icon_close.svg Outdated Show resolved Hide resolved
src/shared/search_bar.rs Outdated Show resolved Hide resolved
src/shared/search_bar.rs Outdated Show resolved Hide resolved
@kevinaboos kevinaboos changed the title Search bar: Add changed,clicked functions and close icon, close event to search bar #123 Rooms listsSearch bar: Add changed & clicked functions, close icon, close event to search bar Oct 30, 2024
@kevinaboos kevinaboos changed the title Rooms listsSearch bar: Add changed & clicked functions, close icon, close event to search bar Rooms lists search bar: Add changed & clicked functions, close icon, close event to search bar Oct 30, 2024
@tyreseluo
Copy link
Contributor Author

That's my problem I didn't describe it clearly, I meant an enhancement to the search bar component. Add Action and clicked events and close icon.

@tyreseluo
Copy link
Contributor Author

tyreseluo commented Oct 31, 2024

For the room search issue #123, I separated it and will be submitting a new PR. As you mentioned in PR #212 , turn some big PRs into some small ones.

@tyreseluo tyreseluo marked this pull request as draft October 31, 2024 01:38
src/home/rooms_sidebar.rs Outdated Show resolved Hide resolved
@tyreseluo tyreseluo changed the title Rooms lists search bar: Add changed & clicked functions, close icon, close event to search bar Search bar (enhancement) : Add right clear icon to clear the search bar value Oct 31, 2024
@tyreseluo tyreseluo marked this pull request as ready for review October 31, 2024 02:23
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok nice, now I understand what the scope of this PR is. It looks good, just one small nit about unnecessary changes to the rooms_sidebar.rs file.

src/home/rooms_sidebar.rs Outdated Show resolved Hide resolved
src/shared/search_bar.rs Outdated Show resolved Hide resolved
@kevinaboos kevinaboos changed the title Search bar (enhancement) : Add right clear icon to clear the search bar value Search bar: add ❌ button to clear the search terms; emit actions upon user input. Oct 31, 2024
@kevinaboos kevinaboos merged commit 9e001e6 into project-robius:main Nov 1, 2024
@tyreseluo tyreseluo deleted the feature/search_bar branch November 1, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants