Properly handle events when the user profile pane is shown #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events that flow into the RoomScreen either get forwarded to the underlying timeline view or the user profile sliding pane. If the pane is currently shown, mouse/touch/tap events are forwarded to the pane *ONLY*, and not the underlying timeline. Other events (e.g., draw events) are always forwarded to the underlying timeline. If the pane is not shown, events are also forwarded to the timeline view, as normal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events that flow into the RoomScreen either get forwarded to the underlying timeline view or the user profile sliding pane. If the pane is currently shown, mouse/touch/tap events are forwarded to the pane ONLY, and not the underlying timeline. Other events (e.g., draw events) are always forwarded to the underlying timeline.
If the pane is not shown, events are also forwarded to the timeline view, as normal.
Solution suggested by @jmbejar.