Configurable Github/Gitea urls #163
Conversation
| @@ -25,10 +25,18 @@ | |||
|
|
|||
| class GithubWebhook extends AbstractWebhook | |||
| { | |||
| public function __construct(Manager $manager, EventDispatcherInterface $dispatcher, ?string $secret = null) | |||
| /** @var array */ | |||
There was a problem hiding this comment.
Please define array shape
| public function __construct( | ||
| Manager $manager, EventDispatcherInterface $dispatcher, | ||
| ?string $secret = null, | ||
| ?array $sourceUrls = ['git_url', 'ssh_url', 'clone_url', 'svn_url'] |
There was a problem hiding this comment.
Can You set this default value directly to property?
| { | ||
| parent::__construct($manager, $dispatcher); | ||
| $this->secret = $secret; | ||
| $this->sourceUrls = $sourceUrls; |
There was a problem hiding this comment.
Please use setter for this property as it is optional and set by default.
|
@ramunasd Can you look at it again, please? Is that what you meant? |
|
The main point was to move out $sourceUrls from __constructor(), because this parameter is optional. Please set default value directly to class property. Setter mut be called from DI, not constructor. |
I have orientated myself on the secret property. Unfortunately, I'm not that deep in the project. Can you describe what you mean in more detail? |
|
I think I was quite clear :) |
|
Thank you very much. |
ramunasd
changed the title
|
Rebased and merged from other branch. |
No description provided.