Return HTTP status code 500 if the build fails #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest to return error status code instead adding params to query. |
|
I am not sure I understand you, what do you mean by We could always return 500 in case of an exit status code !== 0, but it could break existing integrations. |
|
So let's return 500 in case of error. |
Baldinof
force-pushed
the
webhook_500_on_error
branch
from
70aa459 to
1aeadf7
Compare
ramunasd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Currently if during the webhook call something bad happens, the HTTP status code will be 200, and the body will contains the command exit code.
This makes hard for the webhook consumers to know if it failed.
With this PR, if the webhhok URL contains a query parameter
fail_on_error, it will return a 500 response.