Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: stable market tiers #217

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

Arrowana
Copy link
Contributor

@Arrowana Arrowana commented Feb 14, 2022

What is the cost of comparing all those pubkeys? Are we worried?

spl-token seems to use sol_memcmp to do it "cheap"
https://github.com/solana-labs/solana-program-library/blob/master/token/program/src/processor.rs#L872-L876

@armaniferrante
Copy link
Contributor

What is the cost of comparing all those pubkeys? Are we worried?

spl-token seems to use sol_memcmp to do it "cheap" https://github.com/solana-labs/solana-program-library/blob/master/token/program/src/processor.rs#L872-L876

Should be sensitive to this, but likely ok for now. The next version should do this right, but for now there's not a great way to do this in a non breaking way.

@armaniferrante armaniferrante merged commit 4d0a8dc into project-serum:master Feb 14, 2022
@Arrowana Arrowana deleted the fix/stable-market-tier branch June 23, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants