feat: USB hotswapping for replay storage #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a sample of aforementioned game crash btw:
|
the general methodology of this change is as follows 1. copy the technique from HID.c to set up a thread and addition to main loop to manage the IOCTLs and keep track of devices being inserted or removed 2. copy enough of libogc/usb.c and libogc/usbstorage.c in to mount inserted devices 3. modify SlippiFileWriter logic to enable hotswap for usb
yes: on while usb inserted and write thread is keeping up stealth: flash when usb inserted, flash when end of game is successfully written no: no led behavior
I think we got away with this before cuz all __cycle invocations used the same command length. Not sure if this can actually cause errors but for correctness...
|
squashed commits. To reiterate from discord, I've had testers running weeklies for 10 months and larger locals (up to 64 entrants) for 3 months. No regressions or confirmed bugs have been found |
| } | ||
| if (ncfg->Version == 0xC) | ||
| { | ||
| // 0 defaults are fine |
There was a problem hiding this comment.
check if replays are currently enabled and set the LED to stealth if so
| bool failedToMount = false; | ||
| bool hasFile = false; | ||
| bool mounted = true; | ||
| const bool use_usb = ConfigGetUseUSB() != 1; |
There was a problem hiding this comment.
u32 UseUSB = ConfigGetUseUSB(); // Returns 0 for SD, 1 for USB
based on the line above, shouldn't this be const bool use_usb = ConfigGetUseUSB() (== 1);?
There was a problem hiding this comment.
ConfigGetUseUSB refers to ISO device, so file write device is 'opposite'
|
Removed "stealth" Replays LED setting as discussed in discord |
loader/source/menu.c
Outdated
Comment on lines
179
to
185
| "How Drive LED should be used to", | ||
| "indicate replay device status", | ||
| "", | ||
| " [Yes]", | ||
| " Drive LED will stay lit as long", | ||
| " as a replay device is inserted", | ||
| " and working properly.", |
There was a problem hiding this comment.
Suggested change
| "How Drive LED should be used to", | |
| "indicate replay device status", | |
| "", | |
| " [Yes]", | |
| " Drive LED will stay lit as long", | |
| " as a replay device is inserted", | |
| " and working properly.", | |
| "Use the Wii Disc Drive LED", | |
| "to indicate replay device status.", | |
| "The LED will remain on while", | |
| "the replay device is inserted", | |
| "and working properly.", |
NikhilNarayana
approved these changes
Sep 26, 2024
NikhilNarayana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the general methodology of this change is as follows
caveat: as currently implemented, the game will still not boot without the usb replay device inserted. I am working on removing this limitation as a follow-up.
another note: this may require some closed testing before wide use. I encountered some game crashes while implementing. However I believe those were attributable solely to errors at the time. Additionally the crashes always occurred as the game started (between stage select and go) and not during the middle of games
please feel free to @ me in discord if there are any questions or explanations required