Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more UTs #414

Merged
merged 1 commit into from
Feb 25, 2023
Merged

test: add more UTs #414

merged 1 commit into from
Feb 25, 2023

Conversation

rchincha
Copy link
Contributor

Signed-off-by: Ramkumar Chinchani rchincha@cisco.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #414 (bb081ba) into main (89709e6) will increase coverage by 1.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   10.77%   12.15%   +1.38%     
==========================================
  Files          44       44              
  Lines        5421     5421              
==========================================
+ Hits          584      659      +75     
+ Misses       4747     4645     -102     
- Partials       90      117      +27     
Impacted Files Coverage Δ
pkg/lib/dir.go 21.87% <0.00%> (+21.87%) ⬆️
pkg/log/log.go 57.77% <0.00%> (+35.55%) ⬆️
pkg/lib/file.go 53.52% <0.00%> (+53.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rchincha rchincha force-pushed the coverage branch 2 times, most recently from 7ef8411 to 42dbedb Compare February 15, 2023 23:11
pkg/lib/file_test.go Outdated Show resolved Hide resolved
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha rchincha merged commit 7662dbf into project-stacker:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants