Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build and test in github workflows. #432

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

smoser
Copy link
Contributor

@smoser smoser commented Mar 6, 2023

Currently the "Build and test" step of the c-i workflow does both build a binary and test the binary. Make 2 sections 'Build' and 'Test'. This way you can know which of the two sections failed, and also see how long each portion took.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@smoser smoser requested review from rchincha and hallyn as code owners March 6, 2023 16:41
@smoser smoser force-pushed the fix/build-separate-from-test branch from e1001da to 43c3e5f Compare March 6, 2023 16:42
Currently the "Build and test" step of the c-i workflow does both
build a binary and test the binary.  Make 2 sections 'Build' and 'Test'.
This way you can know which of the two sections failed, and also
see how long each portion took.

Signed-off-by: Scott Moser <smoser@brickies.net>
@smoser smoser force-pushed the fix/build-separate-from-test branch from 43c3e5f to 991e293 Compare March 6, 2023 16:45
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #432 (991e293) into main (e577430) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   12.12%   12.12%           
=======================================
  Files          44       44           
  Lines        5433     5433           
=======================================
  Hits          659      659           
  Misses       4657     4657           
  Partials      117      117           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit e31c1c3 into project-stacker:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants