fix(ci): convert ci is failing due to perms

.github/workflows/convert.yaml

@@ -35,10 +35,9 @@ jobs:
           git clone https://github.com/alpinelinux/docker-alpine.git
           chmod -R a+rwx docker-alpine
           cd docker-alpine
-          mkdir -p /out
-          chmod -R a+rwx /out
+          TEMPDIR=$(mktemp -d)
           stacker convert --docker-file Dockerfile --output-file stacker.yaml --substitute-file stacker-subs.yaml
-          stacker build -f stacker.yaml --substitute-file stacker-subs.yaml --substitute IMAGE=alpine
+          stacker build -f stacker.yaml --substitute-file stacker-subs.yaml --substitute IMAGE=alpine --substitute STACKER_VOL1="$TEMPDIR"
           stacker publish -f stacker.yaml --substitute-file stacker-subs.yaml --substitute IMAGE=alpine --skip-tls --url docker://${REGISTRY_URL} --layer alpine --tag latest
           rm -f stacker.yaml stacker-subs.yaml
           stacker clean

cmd/stacker/build.go

@@ -3,7 +3,7 @@ package main
 import (
 	"fmt"
 
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	"stackerbuild.io/stacker/pkg/squashfs"
 	"stackerbuild.io/stacker/pkg/stacker"
 	"stackerbuild.io/stacker/pkg/types"
@@ -20,53 +20,54 @@ var buildCmd = cli.Command{
 func initBuildFlags() []cli.Flag {
 	return append(
 		initCommonBuildFlags(),
-		cli.StringFlag{
-			Name:  "stacker-file, f",
-			Usage: "the input stackerfile",
-			Value: "stacker.yaml",
+		&cli.StringFlag{
+			Name:    "stacker-file",
+			Aliases: []string{"f"},
+			Usage:   "the input stackerfile",
+			Value:   "stacker.yaml",
 		})
 }
 
 func initCommonBuildFlags() []cli.Flag {
 	return []cli.Flag{
-		cli.BoolFlag{
+		&cli.BoolFlag{
 			Name:  "no-cache",
 			Usage: "don't use the previous build cache",
 		},
-		cli.StringSliceFlag{
+		&cli.StringSliceFlag{
 			Name:  "substitute",
 			Usage: "variable substitution in stackerfiles, FOO=bar format",
 		},
-		cli.StringFlag{
+		&cli.StringFlag{
 			Name:  "substitute-file",
 			Usage: "file containing variable substitution in stackerfiles, 'FOO: bar' yaml format",
 		},
-		cli.StringFlag{
+		&cli.StringFlag{
 			Name:  "on-run-failure",
 			Usage: "command to run inside container if run fails (useful for inspection)",
 		},
-		cli.BoolFlag{
+		&cli.BoolFlag{
 			Name:  "shell-fail",
 			Usage: fmt.Sprintf("exec %s inside the container if run fails (alias for --on-run-failure=%s)", stacker.DefaultShell, stacker.DefaultShell),
 		},
-		cli.StringSliceFlag{
+		&cli.StringSliceFlag{
 			Name:  "layer-type",
 			Usage: "set the output layer type (supported values: tar, squashfs); can be supplied multiple times",
-			Value: &cli.StringSlice{"tar"},
+			Value: cli.NewStringSlice("tar"),
 		},
-		cli.BoolFlag{
+		&cli.BoolFlag{
 			Name:  "no-squashfs-verity",
 			Usage: "do not append dm-verity data to squashfs archives",
 		},
-		cli.BoolFlag{
+		&cli.BoolFlag{
 			Name:  "require-hash",
 			Usage: "require all remote imports to have a hash provided in stackerfiles",
 		},
-		cli.BoolFlag{
+		&cli.BoolFlag{
 			Name:  "order-only",
 			Usage: "show the build order without running the actual build",
 		},
-		cli.StringFlag{
+		&cli.StringFlag{
 			Name:  "annotations-namespace",
 			Usage: "set OCI annotations namespace in the OCI image manifest",
 			Value: "io.stackeroci",

cmd/stacker/check.go

@@ -7,7 +7,7 @@ import (
 
 	"github.com/pkg/errors"
 	"github.com/pkg/xattr"
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	"stackerbuild.io/stacker/pkg/log"
 	"stackerbuild.io/stacker/pkg/overlay"
 	"stackerbuild.io/stacker/pkg/stacker"

cmd/stacker/chroot.go

@@ -5,7 +5,7 @@ import (
 	"os"
 
 	"github.com/pkg/errors"
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	"stackerbuild.io/stacker/pkg/container"
 	"stackerbuild.io/stacker/pkg/log"
 	"stackerbuild.io/stacker/pkg/stacker"
@@ -18,12 +18,13 @@ var chrootCmd = cli.Command{
 	Aliases: []string{"exec"},
 	Action:  doChroot,
 	Flags: []cli.Flag{
-		cli.StringFlag{
-			Name:  "stacker-file, f",
-			Usage: "the input stackerfile",
-			Value: "stacker.yaml",
+		&cli.StringFlag{
+			Name:    "stacker-file",
+			Aliases: []string{"f"},
+			Usage:   "the input stackerfile",
+			Value:   "stacker.yaml",
 		},
-		cli.StringSliceFlag{
+		&cli.StringSliceFlag{
 			Name:  "substitute",
 			Usage: "variable substitution in stackerfiles, FOO=bar format",
 		},
@@ -45,14 +46,14 @@ func doChroot(ctx *cli.Context) error {
 	defer locks.Unlock()
 
 	tag := ""
-	if len(ctx.Args()) > 0 {
-		tag = ctx.Args()[0]
+	if ctx.Args().Len() > 0 {
+		tag = ctx.Args().Get(0)
 	}
 
 	cmd := stacker.DefaultShell
 
-	if len(ctx.Args()) > 1 {
-		cmd = ctx.Args()[1]
+	if ctx.Args().Len() > 1 {
+		cmd = ctx.Args().Get(1)
 	}
 
 	file := ctx.String("f")

cmd/stacker/clean.go

@@ -4,7 +4,7 @@ import (
 	"os"
 
 	"github.com/pkg/errors"
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	"stackerbuild.io/stacker/pkg/log"
 	"stackerbuild.io/stacker/pkg/stacker"
 )
@@ -14,7 +14,7 @@ var cleanCmd = cli.Command{
 	Usage:  "cleans up after a `stacker build`",
 	Action: doClean,
 	Flags: []cli.Flag{
-		cli.BoolFlag{
+		&cli.BoolFlag{
 			Name:  "all",
 			Usage: "no-op; this used to do soemthing, and is left in for compatibility",
 		},

cmd/stacker/convert.go

@@ -3,7 +3,7 @@ package main
 import (
 	"log"
 
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	"stackerbuild.io/stacker/pkg/stacker"
 )
 
@@ -18,20 +18,23 @@ var convertCmd = cli.Command{
 func initConvertFlags() []cli.Flag {
 	return append(
 		initCommonConvertFlags(),
-		cli.StringFlag{
-			Name:  "docker-file, i",
-			Usage: "the input Dockerfile",
-			Value: "Dockerfile",
+		&cli.StringFlag{
+			Name:    "docker-file",
+			Aliases: []string{"i"},
+			Usage:   "the input Dockerfile",
+			Value:   "Dockerfile",
 		},
-		cli.StringFlag{
-			Name:  "output-file, o",
-			Usage: "the output stacker file",
-			Value: "stacker.yaml",
+		&cli.StringFlag{
+			Name:    "output-file",
+			Aliases: []string{"o"},
+			Usage:   "the output stacker file",
+			Value:   "stacker.yaml",
 		},
-		cli.StringFlag{
-			Name:  "substitute-file, s",
-			Usage: "the output file containing detected substitutions",
-			Value: "stacker-subs.yaml",
+		&cli.StringFlag{
+			Name:    "substitute-file",
+			Aliases: []string{"s"},
+			Usage:   "the output file containing detected substitutions",
+			Value:   "stacker-subs.yaml",
 		},
 	)
 }

cmd/stacker/gc.go

@@ -1,7 +1,7 @@
 package main
 
 import (
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	"stackerbuild.io/stacker/pkg/stacker"
 )
 

cmd/stacker/grab.go

@@ -5,7 +5,7 @@ import (
 	"strings"
 
 	"github.com/pkg/errors"
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	"stackerbuild.io/stacker/pkg/stacker"
 )
 

cmd/stacker/inspect.go

@@ -10,7 +10,7 @@ import (
 	"github.com/opencontainers/umoci"
 	"github.com/opencontainers/umoci/oci/casext"
 	"github.com/pkg/errors"
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	stackeroci "stackerbuild.io/stacker/pkg/oci"
 )
 

cmd/stacker/internal_go.go

@@ -8,7 +8,7 @@ import (
 	"strings"
 
 	"github.com/pkg/errors"
-	"github.com/urfave/cli"
+	cli "github.com/urfave/cli/v2"
 	"golang.org/x/sys/unix"
 	"stackerbuild.io/stacker/pkg/atomfs"
 	"stackerbuild.io/stacker/pkg/lib"
@@ -19,43 +19,43 @@ import (
 var internalGoCmd = cli.Command{
 	Name:   "internal-go",
 	Hidden: true,
-	Subcommands: []cli.Command{
-		cli.Command{
+	Subcommands: []*cli.Command{
+		&cli.Command{
 			Name:   "cp",
 			Action: doCP,
 		},
-		cli.Command{
+		&cli.Command{
 			Name:   "chmod",
 			Action: doChmod,
 		},
-		cli.Command{
+		&cli.Command{
 			Name:   "chown",
 			Action: doChown,
 		},
-		cli.Command{
+		&cli.Command{
 			Name:   "check-aa-profile",
 			Action: doCheckAAProfile,
 		},
 		/*
 		 * these are not actually used by stacker, but are entrypoints
 		 * to the code for use in the test suite.
 		 */
-		cli.Command{
+		&cli.Command{
 			Name:   "testsuite-check-overlay",
 			Action: doTestsuiteCheckOverlay,
 		},
-		cli.Command{
+		&cli.Command{
 			Name:   "copy",
 			Action: doImageCopy,
 		},
-		cli.Command{
+		&cli.Command{
 			Name: "atomfs",
-			Subcommands: []cli.Command{
-				cli.Command{
+			Subcommands: []*cli.Command{
+				&cli.Command{
 					Name:   "mount",
 					Action: doAtomfsMount,
 				},
-				cli.Command{
+				&cli.Command{
 					Name:   "umount",
 					Action: doAtomfsUmount,
 				},
@@ -95,52 +95,52 @@ func doTestsuiteCheckOverlay(ctx *cli.Context) error {
 }
 
 func doImageCopy(ctx *cli.Context) error {
-	if len(ctx.Args()) != 2 {
+	if ctx.Args().Len() != 2 {
 		return errors.Errorf("wrong number of args")
 	}
 
 	return lib.ImageCopy(lib.ImageCopyOpts{
-		Src:      ctx.Args()[0],
-		Dest:     ctx.Args()[1],
+		Src:      ctx.Args().Get(0),
+		Dest:     ctx.Args().Get(1),
 		Progress: os.Stdout,
 	})
 }
 
 func doCP(ctx *cli.Context) error {
-	if len(ctx.Args()) != 2 {
+	if ctx.Args().Len() != 2 {
 		return errors.Errorf("wrong number of args")
 	}
 
 	return lib.CopyThing(
-		ctx.Args()[0],
-		ctx.Args()[1],
+		ctx.Args().Get(0),
+		ctx.Args().Get(1),
 	)
 }
 
 func doChmod(ctx *cli.Context) error {
-	if len(ctx.Args()) != 2 {
+	if ctx.Args().Len() != 2 {
 		return errors.Errorf("wrong number of args")
 	}
 
 	return lib.Chmod(
-		ctx.Args()[0],
-		ctx.Args()[1],
+		ctx.Args().Get(0),
+		ctx.Args().Get(1),
 	)
 }
 
 func doChown(ctx *cli.Context) error {
-	if len(ctx.Args()) != 2 {
+	if ctx.Args().Len() != 2 {
 		return errors.Errorf("wrong number of args")
 	}
 
 	return lib.Chown(
-		ctx.Args()[0],
-		ctx.Args()[1],
+		ctx.Args().Get(0),
+		ctx.Args().Get(1),
 	)
 }
 
 func doCheckAAProfile(ctx *cli.Context) error {
-	toCheck := ctx.Args()[0]
+	toCheck := ctx.Args().Get(0)
 	command := fmt.Sprintf("changeprofile %s", toCheck)
 
 	runtime.LockOSThread()
@@ -170,12 +170,12 @@ func doCheckAAProfile(ctx *cli.Context) error {
 }
 
 func doAtomfsMount(ctx *cli.Context) error {
-	if len(ctx.Args()) != 2 {
+	if ctx.Args().Len() != 2 {
 		return errors.Errorf("wrong number of args for mount")
 	}
 
-	tag := ctx.Args()[0]
-	mountpoint := ctx.Args()[1]
+	tag := ctx.Args().Get(0)
+	mountpoint := ctx.Args().Get(1)
 
 	wd, err := os.Getwd()
 	if err != nil {
@@ -201,10 +201,10 @@ func doAtomfsMount(ctx *cli.Context) error {
 }
 
 func doAtomfsUmount(ctx *cli.Context) error {
-	if len(ctx.Args()) != 1 {
+	if ctx.Args().Len() != 1 {
 		return errors.Errorf("wrong number of args for umount")
 	}
 
-	mountpoint := ctx.Args()[0]
+	mountpoint := ctx.Args().Get(0)
 	return atomfs.Umount(mountpoint)
 }