Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support dest path for import-http #466

Merged
merged 1 commit into from
May 2, 2023

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented May 1, 2023

Fixes issue #456

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha marked this pull request as ready for review May 1, 2023 21:07
@rchincha rchincha requested review from smoser and hallyn as code owners May 1, 2023 21:07
test/import-http.bats Outdated Show resolved Hide resolved
Fixes issue project-stacker#456

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha rchincha requested a review from smoser May 1, 2023 23:03
Copy link
Contributor

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this good to me. thanks.

@hallyn hallyn merged commit ec76bf9 into project-stacker:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants