Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: restructure nightly tests #480

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Aug 4, 2023

Currently, we run "convert" tests offline/nightly. Define a SLOW_TEST, so that more tests can be added.

Also, rename/redefine nightly ci job.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha requested review from smoser and hallyn as code owners August 4, 2023 20:36
@rchincha rchincha force-pushed the slow-test branch 2 times, most recently from a8b3ee7 to 1fe30b4 Compare August 4, 2023 21:05
@rchincha
Copy link
Contributor Author

rchincha commented Aug 4, 2023

2023-08-04T21:43:27.8638213Z ok 44 convert a Dockerfile in 3sec
2023-08-04T21:43:27.8638890Z ok 45 alpine in 19sec
2023-08-04T21:43:27.8639211Z ok 46 elasticsearch in 157sec
2023-08-04T21:43:27.8639536Z ok 47 python in 1464sec

^ ok so this is working.

Currently, we run "convert" tests offline/nightly.
Define a SLOW_TEST, so that more tests can be added.

Also, rename/redefine nightly ci job.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha
Copy link
Contributor Author

rchincha commented Aug 4, 2023

If SLOW_TEST not set ...

2023-08-04T22:22:05.5266165Z ok 44 convert a Dockerfile in 4sec
2023-08-04T22:22:05.5266829Z ok 45 alpine # skip skipping test since slow tests are not enabled
2023-08-04T22:22:05.5267409Z ok 46 elasticsearch # skip skipping test since slow tests are not enabled
2023-08-04T22:22:05.5267976Z ok 47 python # skip skipping test since slow tests are not enabled

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@hallyn hallyn merged commit 684b586 into project-stacker:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants