Mount previously built squashfs layers if needed #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed my local version of Scott's reproducer anyway. |
hallyn
force-pushed
the
2023-09-10/fix-454
branch
3 times, most recently
from
582f33c to
82ac87d
Compare
hallyn
force-pushed
the
2023-09-10/fix-454
branch
2 times, most recently
from
3794418 to
5ed36df
Compare
When we run a stackerfile a second time, previously built tar layers are assumed to already exist. But if we are using squashfs layers, then those layers are missing on a second run. Make sure to mount them when we find a built layer. Closes project-stacker#454 Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
hallyn
force-pushed
the
2023-09-10/fix-454
branch
from
5ed36df to
7817870
Compare
|
Closing since PR #502 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run a stackerfile a second time, previously built tar layers are assumed to already exist. But if we are using squashfs layers, then those layers are missing on a second run. Make sure to mount them when we find a built layer.
Closes #454
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.